mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-04-27 02:14:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(video): crop all odd resolutions to be even (#15295)

Browse Source
This commit is contained in:
Zach Bloomquist
2021-03-03 14:22:17 -05:00
committed by GitHub
parent 18c7471e83
commit c4e855d3b6
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/lib/video_capture.js
+4 -7
View File
@@ -216,6 +216,10 @@ module.exports = {
return ended.resolve()
})
// this is to prevent the error "invalid data input" error
// when input frames have an odd resolution
.videoFilters(`crop='floor(in_w/2)*2:floor(in_h/2)*2'`)
if (options.webmInput) {
cmd
.inputFormat('webm')
@@ -227,13 +231,6 @@ module.exports = {
// 'vsync vfr' (variable framerate) works perfectly but fails on top page navigation
// since video timestamp resets to 0, timestamps already written will be dropped
// .outputOption('-vsync vfr')
// this is to prevent the error "invalid data input" error
// when input frames have an odd resolution
.videoFilters(`crop='floor(in_w/2)*2:floor(in_h/2)*2'`)
// same as above but scales instead of crops
// .videoFilters("scale=trunc(iw/2)*2:trunc(ih/2)*2")
} else {
cmd
.inputFormat('image2pipe')