mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-02-20 06:01:12 -06:00
Code Issues Packages Projects Releases Wiki Activity

docs: better error handling, ignore timeout errors

Browse Source
This commit is contained in:
Brian Mann
2017-06-16 15:25:40 -04:00
parent ae75db66ea
commit e5dd194519
1 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
docs/lib/url_generator.js
View File

@@ -57,9 +57,15 @@ function assertHashIsPresent (descriptor, source, hash, html, tag = 'url') {
`)
}
function isTimeoutError (err) {
return err.code === 'ETIMEDOUT' || err.code === 'ESOCKETTIMEDOUT'
}
function validateExternalUrl (href, source) {
const { hash } = url.parse(href)
const started = new Date()
return request({
url: href,
timeout: 5000,
@@ -76,9 +82,23 @@ function validateExternalUrl (href, source) {
err.message = `Request to: ${href} failed. (Status Code ${err.statusCode})`
throw err
})
.catch({ code: 'ETIMEDOUT' }, () => {
.catch(errors.RequestError, (reason) => {
// https://github.com/request/request-promise#rejected-promises-and-the-simple-option
const err = reason.error
if (isTimeoutError(err)) {
/* eslint-disable no-console */
const ms = new Date() - started
console.log(`Request to: ${href} timed out. Ignoring this error and proceeding. Waited for ${ms}ms.`)
return
}
/* eslint-disable no-console */
console.log(`Request to: ${href} timed out. Ignoring this error and proceeding.`)
console.log(`Request to: ${href} failed.`)
throw err
})
}