Commit Graph

531 Commits

Author SHA1 Message Date
Chris Breiding
cf87458ba3 Fix issue where click hangs if subject has a shadow root and shadow dom support is not enabled (#7692) 2020-06-12 14:42:57 -04:00
renovate[bot]
33b514424d fix(deps): update dependency commander to version 4.1.1 🌟 (#7686)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-12 14:06:14 +06:30
Zach Bloomquist
d3acf91ea6 fix(types): cy.wait yields previous subject (#7682) 2020-06-12 13:38:02 +06:30
renovate[bot]
fe7937c197 fix(deps): update dependency getos to version 3.2.1 🌟 (#7685)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-12 11:33:51 +06:30
Jennifer Shehane
ae86622dd3 Update types for configuration values that allow string or false (#7674) 2020-06-12 09:54:25 +06:30
renovate[bot]
0e545f9773 fix(deps): update dependency arch to version 2.1.2 🌟 (#7672)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-11 14:15:43 +06:30
Ben Kucera
38cd381b10 replace reporter specPath usage with spec object from config (#7626)
* replace reporter specPath usages with spec object from config

* cleanup, fix specs, fix types tests
2020-06-09 13:46:09 -04:00
Kukhyeon Heo
d0043ff4fd fix: Cypress.Commands.add Type Signature for @typescript-eslint/no-misused-promises rule (#7547) 2020-06-09 09:42:27 -04:00
James Garbutt
a7ff8fddc2 add some shadow dom support (#7469)
Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
2020-06-08 13:05:32 -04:00
Ben Kucera
4cfcae28f0 feat: test config overrides (#5346)
* decaffeinate: Rename browser.coffee from .coffee to .js

* decaffeinate: Convert browser.coffee to JS

* decaffeinate: Run post-processing cleanups on browser.coffee

* temp 02/14/20 [skip ci]

* add beforeEachRestoreRunner to select specs, remove support file hook

* temp 03/03/20 [skip ci]

* fix more specs due to support file change

* fix errored spec

* add isInteractive config to many specs

* update yarn.lock

* use yarn.lock from develop

* fix nested suite configurations

* fix nested suite configurations 2

* force isInteractive in driver/support file

* update more specs to use test config format

* update more specs to use test config format 2

* update more specs to use test config format 3

* update more specs to use test config format 4

* update more specs to use test config format 5

* fix cli/types tests, unit tests

* cleanup

* allow .isBrowser to support array, use .isBrowser for per-test-config

* allow null browser test/suite config value

* temp 04/10/20 [skip ci]

* restore test originalTitle when skip due to browser

* add tests for per-test-config baseUrl

* update .isBrowser error message

* fix rerunning hooks on top navigation

* rename duplicate issue number

* up timeout for server/integration test

* change test to be more specific

* rename TestOptions, add baseUrl test, override xit xdescribe methods

* add tests for xit/xdescribe

* disable video for flaky e2e test

* fix lint-types, e2e snapshot

* try 2: fix rerun before/after hooks

* temp 04/29/20 [skip ci]

* change logic to rerun before hooks after top navigation

* fix windowSize for browser e2e test

* fix windowSize for xvfb chrome in e2e test

* ok fine, just disable screenshots

* perf: faster lookup for hooks without runnables

* fix afterAll hook switch logic

* backport to before/after fix

* backport to before/after fix 2

* fix noExit passed to e2e test inline options

* remove extra root afterhook check

* add issue link..twice

* cleanup function to arrows

* remove Cypress object proxying related code for certain utils

* use getTest() as we did previously

* remove Cypress object proxying related code for certain utils

* fix Cypress._RESUMED_AT_TEST access

* fix Cypress._RESUMED_AT_TEST access 2

* fix runner.getResumedAtTestIndex, state accesses

* fix firefoxgcinterval access

* fix arrow function

* fix firefoxgcinterval access

* try a simpler way to fix afterAll hook issue

* fix decaf after merge

* cleanup internal-types.d.ts

* fix internal-types

* fix comment, getTestFromRunnable signature

* remove unneeded lastTestInSuiteLogic

* fix after merge: many decaffed specs, typedefs

* minor cleanup

* fix typedefs: add taskTimeout

* minor typedef fix, fix more specs modifying config()

* fix e2e snapshot

* fix flake: waiting_spec cancel outstanding XHR between tests

* fix flake

* change config mutation logic, add tests, update typedefs

* add env support to testConfigOverride

* fix specs: remove isInteractive override, add to beforeEach

* move testConfigOverride to file

* finish moving local config logic to cy.js

* fix typedefs cypress.d.ts

* fix minor minor dtslint

* minor spec cleanup

* chunk: typescript spec fixes, bind Cypress.$

* apply chunk: typescript spec fixes, bind Cypress.$

* fix stop-only

* fix stop-only 2

* extend the jqueryProxyFn in the constructor

* remove experimental code

* rename spec files for overrides, cleanup

* rename snapshots + tests to match updated test config overrides

* fix firefox flake: navigation_spec

Co-authored-by: Brian Mann <brian.mann86@gmail.com>
2020-06-04 11:26:11 -04:00
Kukhyeon Heo
128f2eb69e Add type for Cypress.automation (#7573) 2020-06-04 21:34:33 +06:30
Ben Kucera
f93f46cde8 fix typedefs for cy.screenshot options, Cypress.log (#7445) 2020-06-03 12:26:59 -04:00
Ben Kucera
f6613bd6fc fix typedefs: add taskTimeout to cypress config (#7521) 2020-05-29 10:14:25 -04:00
Hossam Magdy
071c5c74c6 feat(driver): Add support for encoding option in cy.request() (#7382) 2020-05-26 15:13:32 -04:00
Gleb Bahmutov
0dbd6304c8 Split types files again (#7403) 2020-05-18 19:25:52 -04:00
Gleb Bahmutov
2e5bb50706 Update a few missing TS types in CLI to get Kitchensink types check to pass (#7401) 2020-05-18 18:02:54 -04:00
Zach Bloomquist
a854089c77 fix(types): use SinonStatic for Cypress.sinon type (#7398) 2020-05-18 14:31:45 -04:00
Gleb Bahmutov
a2c0bc3e3e include CLI TS types in a way to avoid clashing with Jest (#7352) 2020-05-15 17:31:22 -04:00
Zach Bloomquist
6960f7cd78 Rewrite JS/HTML using AST-based approach (#5273)
* Add winPropAccessor to security.js, remove other replacers

* Add start of Cypress.resolveWindowReference

* Add regexes for dot and bracket access

* Some security_spec tests pass with new injection

* Add resolveWindowReference unit tests

* Old security_spec now passes with resolveWindowReference

* Inject stub resolveWindowReference so proxy still works outside of Cypress

* wip: rewrite HTML + JS with tokenizer

* Move to using esprima + hyntax to rewrite JS + HTML

* remove comment; oneLine makes the whole thing commented

* Fix tests, apple.com edge case

* wip: add getOrSet

* Revert "wip: add getOrSet"

This reverts commit a5c647c00f.

* release 3.5.0 [skip ci]

* use recast to replace window property accesses

* replace assignments to top properly

* fix yarn.lock

* bump deps

* update integration tests

* remove old security ts?

* fix integration spec

* always ignore js interception failure

* use globalThis instead of window

* add experimentalSourceRewriting flag

* restore regex-writer spec

* fix types

* update config_spec

* add source rewriting spec

* cleanup

* simplify rewriting logic, move rules into rewriter package

* create threaded rewriting tool for non-streaming use

* update @packages/rewriter to use threads for async

* use async rewriting where convenient

* add worker-shim.js

* add performance info to debug logs

* properly handle +=, -=, ...

* add proxy, rewriter to unit-tests stage

* cleanup

* use parse5 to rewrite HTML, strip SRI

* update tests

* reorganization, cleanup

* rewrite ALL parent, top identifiers except in a few cases

* handle many JS edge cases

* ensure parse5@5.1.1 is installed

* update yarn.lock

* update tests

* add debugging, add tests

* add attempted repro for .href issue

* implement source maps + extending inline source maps

* update opts passing in proxy layer

* fix sourcemap naming structure

* update tests to account for sourcemaps

* sourcemap tests

* remote source maps work

* comment

* update rewriter tests

* clean up TODOs in resolveWindowReference

* remove @types/nock

* clean up todos in deferred-source-map-cache

* fix rewriter build script

* fix concatStream import

* bump expectedresultcount

* clean up js-rules

* threading improvements, workaround for Electron segfault

* no visit_spec for now

* fix 6_visit_spec

* update MAX_WORKER_THREADS

* add repro for #3975

* cleanup

* cleanup

* make better use of namedTypes and builders

* get rid of the horrific closureDetectionTernary

ast-types keeps track of scope, so it is unneeded

* fix #3975, #3994

* add x-sourcemap, sourcemap header support

* snap-shot-it 7.9.3

* add deferred-source-map-cache-spec

* add tests

* Throw error in driver if AST rewriting fails

* Fix "location = 'relative-url'"

* fix max recursion depth

* slim down some fixtures

* fix window.location usage

* don't mess with `frames` at all

* no integration tests

* skip testing apple.com for now

* update wording: regex-based vs. ast-based

* skip real-world tests for now

* add some padding to process.exit workaround

* fix resolvers_spec

* fix html-spec

* cleanup

* Update packages/rewriter/lib/js-rules.ts

* Update packages/driver/src/cypress/resolvers.ts

* just import find by itself

* privatize typedefs for Cypress.state, remove .gitignore, remove dead code

Co-authored-by: Ben Kucera <14625260+Bkucera@users.noreply.github.com>
2020-05-11 12:54:14 -04:00
renovate[bot]
885fb352bf chore(deps): Update dependency snap-shot-it to version 7.9.3 🌟 (#7283) 2020-05-11 14:21:18 +06:30
Gleb Bahmutov
627c9deb08 add TS types for partial config options (#7239) 2020-05-07 10:39:31 -04:00
Dmitriy Kovalenko
379a9e7008 feat: improve component based tests approach (#5923)
- new mode that mounts the spec iframe instead of application iframe
2020-04-26 16:25:24 -04:00
Jennifer Shehane
79379a96d2 Replace deprecated babel-preset-es2015 (#6770)
* replace deprecated babel-preset-es2015

* use correct name for env preset

* use @babel/cli instead of babel-cli

Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
2020-04-24 11:45:27 +06:30
Xander Dumaine
5a64934c66 Correct typing of CypressRunResult::runs (#6127)
* Add a type for CypressFailedRunResult distinct from CypressRunResult

* add back @example for detecting cy run failure

* remove trailing whitespaces found in dtslint

Co-authored-by: Joseph Weissman <61561354+CypressJoseph@users.noreply.github.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
2020-04-14 15:17:13 +06:30
Gleb Bahmutov
3b6514399d Do not silence cli commands (#6909)
* always log cache path

* cache list always logs

* cypress version should always log result
2020-04-01 11:44:27 -04:00
Zach Bloomquist
b6703aaec7 Add support for sameSite in cookie-related commands (#6828)
* add experimental feature for sameSite

* allow experimental descriptions to render markdown

* sameSite support mostly working

* also strip sameSite from setCookie yielded value

* don't use `unspecified` - let browser set default

* add tests

* decaffeinate: Rename cdp_automation_spec.coffee from .coffee to .js

* decaffeinate: Convert cdp_automation_spec.coffee to JS

* decaffeinate: Run post-processing cleanups on cdp_automation_spec.coffee

* cleanup cdp_automation_spec.ts

* update unit tests

* update settings_spec to not render as markdown

* user-friendly error for insecure SameSite=None

* fix styling

* fix markdown renderer

* update types + schema

* use renderInline

* update experiment summary

* bind renderFn to md
2020-03-27 10:04:50 -04:00
Karl Horky
d7f6f61678 Upgrade extract-zip to address vulnerability (#6845)
* Upgrade extract-zip to address vulnerability

Versions of extract-zip before `1.6.8` depended on a vulnerable version of `minimist` via `mkdirp`:

https://github.com/maxogden/extract-zip/pull/85#issuecomment-603563097

Minimist vulnerability: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764

* Update Yarn lockfile
2020-03-26 16:24:04 +06:30
Gleb Bahmutov
095e2a3550 add tag to Cypress NPM module API options (#6796) 2020-03-25 15:57:09 +06:30
Joseph Weissman
2673a47c9b Document how to reproduce ts@next dtslint issues 2020-03-23 11:03:43 -04:00
Zach Bloomquist
d810950379 Switch request, request-promise to @cypress/ forks (#6777) 2020-03-19 11:48:24 +06:30
Zach Bloomquist
47410d50e5 Fix "Parse Error" when performing HTTP requests (#5988)
* Detect if NODE_OPTIONS are present in binary; if not, respawn

* Always reset NODE_OPTIONS, even if no ORIGINAL_

Co-authored-by: Andrew Smith <andrew@andrew.codes>

* Exit with correct code # from stub process

* Clean up based on Brian's feedback

* how process.versions is null, i have no idea, but it is

* add repro for invalid header char

* Always pass NODE_OPTIONS with max-http-header-size (#5452)

* cli: set NODE_OPTIONS=--max-http-header-size=1024*1024 on spawn

* electron: remove redundant max-http-header-size

* server: add useCli option to make e2e tests go thru cli

* server: add test for XHR with body > 100kb via CLI

* clean up conditional

* cli: don't pass --max-http-header-size in dev w node < 11.10

* add original_node_options to restore o.g. user node_options

* force no color

* Revert "Use websockets to stub large XHR response bodies instead of hea… (#5525)"

This reverts commit 249db45363.

* fix yarn.lock

* update 4_xhr_spec snapshot

* make 6_visit_spec reproduce invalid header char error

* pass --http-parser=legacy

* still set headers if an ERR_INVALID_CHAR is raised

* add --http-parser=legacy in some more places

* update http_requests_spec

* readd spawn_spec

* improve debug logging

* remove unnecessary changes

* cleanup

* revert yarn.lock to develop

* use cp.spawn, not cp.fork

to work around the Electron patch: 39baf68790/patches/node/refactor_alter_child_process_fork_to_use_execute_script_with.patch

Co-authored-by: Andrew Smith <andrew@andrew.codes>
2020-03-18 17:26:22 -04:00
renovate[bot]
5dfdab19f1 fix(deps): Update dependency minimist to version 1.2.5 🌟 (#6747)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
2020-03-17 14:02:07 +06:30
Kukhyeon Heo
ee494d04ee Added TypeScript type checker + Fixed type errors. (#5780)
* Added type_check.js

* Now checks cli, too.

* Ignored a line that should fail.

* Removed cli shims and post-install.

* Updated @types/chai to fix type error.

* Fixed keyboard type errors.

* Updated typescript to 3.7.2 to fix window.Node error in dom/document.

* Removed tsconfig errors that caused type errors in reporter and runner.

* Ignored error test by dtslint. Becaust it's done by type_check.js

* Added npm command.

* Added it to CI.

* Added skipLibCheck option.

* Removed checking chai folder existence.

copy of chai is unnecessary.

* Added 'ignore-progress' option for CI.

* Show success message when type check is finished successfully.

* Use ignore-progress option on CI.

* Moved type definitions from devDependencies to dependencies.

* Fixed new type errors after rebase.

* Updated type errors.

* Removed cli. Because its types are checked by dtslint.

* type_check -> type-check for consistency.

* Updated json-schema.

* Updated blob-util.

* Fix wrong command in CI.

* Revert "Updated blob-util."

This reverts commit e46549af54.
Because it's a breaking change.

* Remove copies of @types if exists.

* Fix stream buffer type error.

* Fix type errors in ui-components.

* Fix type failure.

* Fix lint error.

* Fix type errors

* Regenerate yarn.lock

* Fix type error.

* Fix type failures.

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
2020-03-17 11:01:31 +06:30
Jennifer Shehane
28fa3c7421 Add more checks for el existence before traversing up parent els (#6708)
* add check within getFirstStickyPositionParent for $el[0] to exist

- pull out check for undefined or html/body/doc element into a shared
elements method.

* prevent more checks on undefined parents & els causing getComputedStyle to throw

* yarn-lock

* Expand isUndefinedOrHTMLBodyDoc to Cypress.dom + add types

* Add unit tests for isUndefinedOrHTMLBodyDoc method

* yarn-lock

* move 'el[0]' existence check to below other checks (right when it's needed)

* yarn-lock
2020-03-16 20:34:49 +06:30
Gleb Bahmutov
333ab85324 add Cypress.sinon type (#6725) 2020-03-16 09:17:05 -04:00
Jennifer Shehane
c40461fa22 Don't print 'first time' message if verification is running fro… (#6640)
* don't like 'first time' message if verification is running from 'cypress verify'

* updates snapshots to remove 'first time message' from verify specs
2020-03-16 12:18:38 +06:30
renovate[bot]
aad48602a4 fix(deps): Update dependency minimist to version 1.2.2 🌟 (#6726)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-16 11:41:50 +06:30
Zach Bloomquist
910ac6f077 Electron 8.1.1 (#6555)
* electron@8.1.0

* set app.allowRendererProcessReuse to true

https://github.com/electron/electron/issues/18397

* Fix taking screenshots in Electron with debug logs enabled

* explicitly use png format for Page.captureScreenshot

* don't need to do Network.enable

i believe this was done because we thought it was needed for Network.getCookies, etc, but it does not seem to be used

* yarn.lock

* remove dead code

* start and stop screencast around electron screenshots

* update debug logging

* cypress/browsers:node12.13.0-chrome80-ff73

* fix unit tests

* debug e2e tests

* detect first available servernum

* electron@8.1.1

* no reuse

* Revert " cypress/browsers:node12.13.0-chrome80-ff73"

This reverts commit 404803a169.

* cypress/browsers:node12.13.0-chrome80-ff74

* Revert "debug e2e tests"

This reverts commit 7a09e3630e.

* Revert "detect first available servernum"

This reverts commit 7ac95072b2.
2020-03-13 14:36:08 -04:00
Jennifer Shehane
c650c91ac0 sync all 'request' deps to use the cypress fork (#6694) 2020-03-11 21:42:14 +06:30
Joseph Weissman
c5c484e272 Improve types for cy.its() with property paths (#6667)
Improve types for cy.its() with property paths
- provides additional signature for `cy.its()`
- adds kitchen sink examples for path-based property access
- improve typing for its/invoke
2020-03-11 11:00:19 -04:00
Gleb Bahmutov
2a0bc32700 cypress cache list prints last accessed date (#6627)
* get last access timestamps and print with cache versions

* remove done TODO

* start trying to save HTML but only after snapshot text is confirmed

* store cli test output HTML as static pages

* set our color for table heading

* make code readable

* lock file again

* update saved HTML file

* refactor cache spec

* add test with no access time:
2020-03-09 09:27:54 -04:00
Joseph Weissman
a565a77700 Characterize overloaded signatures of cy.clearLocalStorage more… (#6652)
* Characterize overloaded signatures of cy.clearLocalStorage more carefully

* capture clearLocalStorage signatures in kitchen sink tests
2020-03-09 10:32:43 +06:30
Joseph Weissman
22a6420b4b Provide more narrow type for click position
- Now gives intellisense feedback for valid arguments
  to click/dblclick/rightclick
2020-03-06 12:18:12 -05:00
Jennifer Shehane
2ba53f6837 Better handle reserved key CYPRESS_ENV being set by users to va… (#6437)
* Add warning when setting CYPRESS_ENV to non-production value

* Add warning and update error when setting CYPRESS_ENV in config to non-production value

* Update config test/to throw

* we want warning, not throw

* Rename env var to CYPRESS_INTERNAL_ENV + fix warning to actually warn when staging

* update cli snapshot to include new 'info' command

* yarn.lock

* removed the warning from config, is overboard on our own tests 😓

* cleanup from review

Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
2020-03-06 16:53:48 +06:30
Kyle Roberts
855657d334 Add Cypress.dom.* to TS type declarations (#5298)
* add isDetached to type declaration

* add rest of dom function declarations

* remove any type union

* remove duplicate declaration

* add docstrings for documented types

* .js => .ts

* update types + tests

fix ts lint

* add Cypress.dom type tests

Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
2020-03-02 14:22:13 -05:00
Chris Breiding
778321786f Pass projectRoot and configFile to plugins file through config (#6317)
* decaffeinate: Rename index.coffee from .coffee to .js

* decaffeinate: Convert index.coffee to JS

* decaffeinate: Run post-processing cleanups on index.coffee

* refactor decaffeinated plugins/index.js

* decaffeinate: Rename 3_plugins_spec.coffee from .coffee to .js

* decaffeinate: Convert 3_plugins_spec.coffee to JS

* decaffeinate: Run post-processing cleanups on 3_plugins_spec.coffee

* fix wrongly removed return

* refactor e2e plugins spec, update snapshot

* pass env argument to plugins file

* decaffeinate: Rename index_spec.coffee from .coffee to .js

* decaffeinate: Convert index_spec.coffee to JS

* decaffeinate: Run post-processing cleanups on index_spec.coffee

* update plugins tests

* update scaffold snapshot

* add back server test script and document running individual tests

* add projectRoot and configFile directly to config

* normalize browsers in snapshot

* add types for configFile and projectRoot

* fix linting issues

* return return

* Merge

* remove file

* remove unnecessary returns
2020-02-28 14:13:36 -05:00
Gleb Bahmutov
4e11b5bdde cli: downgrade chalk (#6569)
* cli: downgrade chalk

* add job to test NPM on minimum Node version

* forgot to attach workspace

* try updating npm

* try installing npm 5.0.4

* try npm 5.1.0

* skip npm init, just install Cypress

* try using Yarn

* run additional Cypress commands

* print Cypress version

* print Cypress version

* hmm, try different user

* yarn-lock

* back to npm

* print npm version

Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
2020-02-28 10:25:25 +06:30
Ben Kucera
f77ec01c18 chore:fix ui-components dependencies, web-config deps for yarn (#6534)
- add needed deps in `ui-components` package
- upgrade `@cypress/webpack-preprocessor`
- refactor some eslint code, remove unused eslint scripts
- rename `build-js` scripts to `build-prod` since they'll only need to run when building for prod / checking for tsc errors
2020-02-26 20:21:23 +00:00
Jennifer Shehane
e585079c56 Roll back execa to 1.0.0 to actually support Node 8.0.0 (#6560) 2020-02-26 22:22:28 +06:30
renovate[bot]
eab801ae3f chore(deps): Update dependency eslint to version 6.8.0 🌟 (#6509)
* chore(deps): Update eslint to 6.8.0 🌟

* fix missing dangling commas for linter

* fix missing dangling commas for linter

* more lint fixes

* yarn lock

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
2020-02-25 00:09:47 +06:30