Commit Graph

91 Commits

Author SHA1 Message Date
Kukhyeon Heo
2d119ad46a chore: Intregrate runner packages. (#23028)
* chore: Intregrate runner packages.

* Remove unnecessary Studio react files.

* Remove unnecessary gif

* runner-shared to runner-ct.

* fix path.

* fix package.json

* Remove scss files from runner-ct

* Remove runner-ct

* Remove runner-shared and runner-ct comments.

* Feedback

* chore: reduce parallelism for reporter-componen-tests

* chore: reduce paralelleism

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
2022-08-11 14:07:10 +10:00
Lachlan Miller
a710aaf154 chore: update docs for npm directory (#22916)
* chore: add docs to npm directory

* Fix binary build failure caused by non-JSON file at `/npm`

* chore: simplify docs

* revert

* fix build

Co-authored-by: Mike Plummer <mikep@cypress.io>
2022-07-28 11:47:37 +10:00
Mark Noonan
3f751a05a8 docs: fix typo in review instructions (#22546) 2022-07-01 16:18:50 -04:00
Bill Glesias
a481dbb682 chore: document internal vite options (#21667)
* chore: document internal vite options

* try to make pertinant internal dev options more discoverable

* move vite internal references to contributing guide and rebuild references

* fix typo

* Update npm/vite-dev-server/README.md

* add enabling flag for cypress internal vite inspect

* update contributing guide to follow similar wording for internal vite envs
2022-06-13 16:07:18 -04:00
Bill Glesias
b24a77dd23 chore: update windows contributing guide to have users set default shell script to command prompt (#22149) 2022-06-07 11:32:22 -04:00
Jon Hermansen
d87b00ba40 docs(CONTRIBUTING): Fix link to "good first issue" for newcomers (#21614)
Co-authored-by: Matt Schile <mschile@gmail.com>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Zach Bloomquist <git@chary.us>
2022-05-26 15:30:47 +00:00
Adam Murray
2fb0cf9a7c docs: remove gitter link in contributing guide. (#21592) 2022-05-25 16:30:22 -05:00
Zach Bloomquist
3c0c864fa9 chore: clean up debug statements in preparation for 10.0 release, add debug docs (#21621)
Co-authored-by: Muaz Othman <muazweb@gmail.com>
2022-05-25 17:40:04 +00:00
Tim Griesser
47b1f38f62 Merge branch 'develop' into 10.0-release
* develop: (35 commits)
  fix(deps): update dependency url-parse to v1.5.6 [security] (#20270)
  chore: fix cache keys to include PLATFORM (#20279)
  chore: fix server performance flake (#20271)
  test(system-tests): support docker-based tests against built binary (#20250)
  chore: fix system-test-firefox screenshots_spec flake (#20268)
  chore(deps): update dependency fs-extra to v9 🌟 (#19939)
  fix: Wait for child process to be ready (#19792)
  fix: treat form-data bodies as binary (#20144)
  test: replace cypress-test-example-repos coverage + remove bump (#20186)
  fix(driver): update wrapErr to ignore number and boolean values (#20172)
  release 9.5.0 [skip ci]
  chore: Update Chrome (stable) to 98.0.4758.102 (#20192)
  chore: enable volar.takeOverMode
  Add span names, merge develop
  fix: Update `.type(' ')` to not emit clicks when the keyup event has been prevented (#20156)
  test: remove redundant "other projects" CI jobs (#20133)
  chore(driver): move cy.focused and cy.root into their own files (#20054)
  Move sending root event to own script
  chore: release @cypress/vue-v3.1.1
  chore: release @cypress/react-v5.12.3
  ...
2022-02-22 12:40:07 -05:00
Zach Bloomquist
42b0fce6dc test: replace cypress-test-example-repos coverage + remove bump (#20186) 2022-02-16 18:53:04 +00:00
Emily Rohrbough
f669c101e1 Merge branch '10.0-release' into 1f70b21bc4-develop-into-10.0-release 2022-01-21 15:50:16 -06:00
kanazawa
bf54930090 docs: fix typo in CONTRIBUTING.md (#19480) 2022-01-03 08:46:05 -06:00
ElevateBart
ce0bb2c84b Merge branch 'develop' into elevatebart/chore/merge-develop 2021-12-07 10:41:18 -06:00
Zach Bloomquist
42dfb8abb1 docs: add info around next version, testing other projects (#19157)
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Emily Rohrbough  <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Tyler Biethman <tbiethman@users.noreply.github.com>
2021-12-02 15:35:51 +00:00
Jessica Sachs
0975fec79b chore: merging in from develop into 10.0-release (#19148) 2021-11-30 14:32:08 -05:00
Ryan Manuel
31646ccf7a docs: Fix a minor typo in CONTRIBUTING.md (#19143) 2021-11-29 23:42:00 +00:00
Dmitriy Fishman
ec3ab389c2 docs: Fix a typo in CONTRIBUTING.md (#19123) 2021-11-29 11:05:04 -06:00
Tim Griesser
d0cf250f57 refactor: remove @packages/desktop-gui (#19127)
* chore: Remove references to desktop-gui in CI & scripts

* More path updates

* Remove desktop-gui cypress tests

* remove add:project

* remove begin:auth

* remove close:browser

* remove close:project

* remove external:open

* remove get:current:user

* remove get:orgs

* remove gui:error

* remove get:runs

* remove get:options

* remove get:projects

* remove get:project:statuses

* remove get:project:status

* remove get:dashboard:projects

* remove get:record:keys

* remove get:release:notes

* remove get:specs

* remove get:user:editor

* remove set:user:editor

* remove launch:browser

* remove log:out

* remove on:focus:tests

* remove: on:menu:clicked

* remove open:file

* remove open:finder

* remove open:project

* remove on:config:changed

* remove on:spec:changed

* remove on:project:error

* remove on:project:warning

* remove ping:api:server

* remove ping:baseUrl

* remove remove:project

* remove request:access

* remove setup:dashboard:project

* remove set:project:id

* remove requestAccess

* remove show:directory:dialog

* remove show:new:spec:dialog

* remove updater:check

* remove updater:run

* remove window:open/close

* remove new:project:banner:closed

* remove has:opened:cypress

* remove remove:scaffolded:files

* remove set:clipboard:text

* remove set:prompt:shown

* ipc & static method cleanup

* remove packages/desktop-gui

* bump yarn.lock, standardize webpack version

* bump yarn.lock
2021-11-29 08:58:32 +10:00
Zach Bloomquist
fc83e646ec Merge branch 'develop' into 9.0-release 2021-11-08 16:06:18 +00:00
Jennifer Shehane
489be7a48f docs: Add instructions to squash commits to develop in Contributing (#18728) 2021-11-01 12:28:37 -06:00
Emily Rohrbough
e396956534 feat: remove windows 32-bit support (#18630)
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Zach Bloomquist <git@chary.us>
2021-10-29 08:54:02 -05:00
Jessica Sachs
a045e4f59a chore: move server e2e tests to system-tests (#16354)
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Zach Bloomquist <git@chary.us>
Co-authored-by: Zach Bloomquist <github@chary.us>
2021-10-18 19:53:14 +00:00
Jennifer Shehane
98ecdd5879 docs: General updates to contributing guide (#18283)
Co-authored-by: David Munechika <david@cypress.io>
2021-10-07 13:40:55 -05:00
Tim Griesser
339b642490 chore: remove unused @packages/static (#17961) 2021-09-01 12:29:07 -04:00
Lachlan Miller
07127f945e chore: update contributing documentation (#17797) 2021-08-18 22:50:30 -04:00
Jennifer Shehane
5ced6abb2d docs: Add README for some newly added packages (#17283)
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
2021-07-14 09:38:38 -05:00
Scott Gunther
03ab08d38f fix: warn on EPERM for project directory just like EACCES (#16934) 2021-06-22 14:41:32 +00:00
Jennifer Shehane
46e9b30660 Update requirements to run Cypress locally to include python install. [skip ci] (#16204) 2021-04-26 18:49:13 -05:00
Jessica Sachs
a4bef60e2a chore: cherry-picking conditional CI changes into master and fixing releaserc.js (#15571)
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
2021-03-18 20:59:57 -04:00
Jennifer Shehane
d945728e78 chore: TR-479 Remove decaffeinate tasks (#14586) 2021-01-21 22:51:46 +06:30
Kevin Grüneberg
0bf602c56d chore: Replace deprecated node-sass (#14409) (#14415)
Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
2021-01-11 10:35:00 -05:00
Paulina Wilk
e12e178248 docs: links to issue template in contributing guideline (#9741)
* issue-9740 fix links to issue template in contributing guideline

* Update template links query params

Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
2020-12-14 12:48:47 +06:30
Martin Staffa
d5eadc23ae docs(contributing.md): remove "Testing" toc entry (#9198)
The Committing > Testing section was removed in 5842d1dffe
2020-11-16 08:53:43 +06:30
Zach Panzarino
5842d1dffe build: conditional CI jobs, dynamic test requirements for release, updated independent package release process (#8730) 2020-10-28 18:03:28 -04:00
Jessica Sachs
1b3d39b760 docs: fixing the diagrams in CONTRIBUTING.md 2020-09-29 21:06:59 -04:00
Zach Panzarino
156a626b7f docs: update internal docs for monorepo (#8688)
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
2020-09-29 20:30:22 -04:00
Gleb Bahmutov
0c30744089 chore: adding section on common issues with links (#8583) 2020-09-17 11:43:37 -04:00
Gleb Bahmutov
17e99b0dab chore: expand browsers component spec (#8286)
Co-authored-by: Zach Bloomquist <github@chary.us>
2020-09-11 09:49:07 -04:00
Jennifer Shehane
1690d41d76 docs: Update triage for actions taken for questions (#8207)
We do not offer premium support anymore.
2020-08-07 11:56:05 +06:30
Jennifer Shehane
e1f9c80594 docs: Update contributing to mention titling PRs with semantic-release (#8125)
* Update contributing to mention titling PRs with semantic-release

* Update CONTRIBUTING.md link
2020-07-31 02:38:21 +06:30
Zach Bloomquist
0e632635cd chore: rm non-test-related coffeescript references 2020-06-10 10:49:31 -04:00
Jennifer Shehane
eed4934885 chore: move instructions for code reviews into Contributing guide (#7630) 2020-06-09 09:18:54 -04:00
Zach Bloomquist
1875027073 chore: decaffeinate server tests, scripts, other files (#7591) 2020-06-05 15:12:53 -04:00
Jennifer Shehane
208b01cb1f Add note to contributing about yarn bug + instructions for adding on links (#7384) 2020-05-20 10:55:13 +06:30
Jennifer Shehane
166aab4077 Updated contributing and PR review comment to recommend Draft P… (#7085) 2020-04-21 13:35:04 +06:30
Cecelia Martinez
4b75da5963 fixes broken links and typos outlined in issue-6373 (#6396)
* fixes broken links and typos outlined in issue-6373

* updates additional link for issue-6373

Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
2020-02-11 22:40:48 +06:30
Andrew Smith
0a6a2abcec Replace npm with yarn (#5555)
* enable using yarn

* enable lerna and yarn workspaces

No longer can reliably access node_modules via thei node_modules directory; yarn may optimize it via hoisting it up. This meant updating JS tasks that were copying files directly from node_modules directories. In these cases, pulled in a new package to resolve these correctly.

SCSS files remain impacted, but cannot easily import via JS. These paths have been modified, but it feels dangerous and incorrect to reach into a node_module to grab files like this.

Many prebuild steps were removed. I **think** the purpose of `check-deps-pre` is no longer needed, but need to confirm this.

* enabling test-unit script

removal of pretest-unit due to check-deps-pre

* removal of all  `check-deps` and `check-deps-pre`

I do not think these are needed anymore

* remove npm run all

Replaced by `lerna run` and `lerna run --scope`

* use yarn in circle CI

appveyor to soon follow

* yarn in appveyor

* remove need for bin-upplaces using bin-up have a dev dependency on some package; mostly mocha. This mocha package will be optimized by yarn workspaces by hoisting it into the root; which is effectively what bin-up usage was mimicing.

* replace npm run with yarn in package files

* replace explict paths to internal packages with yarn bin

* remove unecessary link packages script and references

* properly require package for mocha

* removing yarn test in this package as it was just a proxy for test-*

* yarn test in root now reflects what is run in circle ci

* relax yarn version requirement for circle ci

* @packages/cli is really just cypress

also run test in parallel via `yarn test`; it runs test in all 10 packages

* ensure postinstall is called before prebuild

yarn does not call postinstall when nothing has installed; such is the case when everything has been cached

* vscode config uses yarn

* cannot rely on which node_modules dir a package is in

find the right node_module dir via `resolve-pkg`

* further relax yarn version for OSX build in circle ci

* resolve failing test

Regarding direct access to node_modules

* node version in mac build not sufficient

ignoring check of node/yarn versions when installing

* preinstall script does not exist

I **think** the reason to not install packages' modules (the reason for `--ignore-scripts` may be irrelevant with yarn workspaces managing the packages)

* upgrade mocha that was using --file

`--file` was introduce in >=5

* scope test runs to correct packages

* explictly close connections; otherwise script hangs after tests run

* refactor so npm and npx commads can be created

npx is used to utlize lerna for running across all packages sans cli

* properly resolve socket.io-client node_module

We cannot reach directly into node_modules to grab the socket.io-client file. Furthermore, running it locally will require resolving from a different cwd, the repo root, as opposed to the package's dist directory.

The existence of the file deterimes whether we are building the binary or running locally.

* remove unnecessary arg in vscode debug config

enable debugging in @packages/server to troubleshoot failing test

* another npm command found to be changed to yarn

* properly print colors to terminal

`lerna run` does not appear to print colors to the terminal properly. Changed to leverage `lerna exec`

See https://github.com/lerna/lerna/issues/1168

* add missing test scripts to packages that have partially have them

'test', 'test-unit', 'test-watch', and 'test-debug'

This makes running them from the root easier and enables debugging via IDE on more packages

* properly patch package in yarn workspaces

* another package needing to postinstall

* use existing script over explicit lerna exec

* patches must be copied to dist

* return to building on postinstall

* do not hoist driver's packagesThere are too many places we need driver's packages to not be hoisted when testing. We have *.html files in test with script tags srcing node_modules.

* wait-on is used in circle-ci and needs to be a root dep

No longer hoisted by `@packages/driver`. This previously worked only because it was hoisted. Adding it to root properly.

* update documentation based on new ergonomics

* launcher has unit tests that should be runnable via top level task

* more concise way to run build within cypress scope

* fix for unit test that never seemed to work

`getPathToExample` is really `getPathToExamples`

* bust cache based on yarn.lock changing

* define intra-dependencies among packages

Due to the way we build the binary, all are considered dev dependencies.

* address `jquery.scrollto` mismatched jquery version

Tell yarn to explicitly resolve `jquery@3.1.1` for any dependencies and sub-dependencies. The root issue is that `jquery.scrollto` package specifies jquery as a dependency instead of a peer dependency (which is correct). Its jquery version is set to the `>=1.8` which then resolves to 3.4.1. In doing so, it will patch its jquery instead of ours; meaning that `$.scrollTo` is not defined.

* add/remove deps from renovate

- bin-up is gone in favor of yarn workspaces and lerna from root
- check-deps is gone in favor of `yarn check --integrity`
- lerna added

* few misc yarn lock updates

* hope that this may speed up build binary

installing several of the same dep in >1 package will likely be sped up using yarn due to its machine-wide caching.

* yarn pack prefix version with a `v`

* auto-run `yarn install` when deps become out of date

When switching to a branch with a different set of required deps, running any of the main top level tasks (as seen in the `./CONTRIBUTING.md` guide) will check for deps changes via `yarn check --integrity` and run `yarn` in root if deps are out of sync.

* add clean top level task, remove prebuild

install => build => prebuild => check => install === no good

* address code review to undo formatting changes

* favor default imports over deconstructing imports

* favor @package resolution; pr feedback

* include a specific revision

for some reason, it cannot resolve the original SHA `29dafed297142d3b8a9d8a01842cbdf249a98b72`

using the next closes SHA

* properly cache yarn packagesfollowed guide: https://circleci.com/docs/2.0/yarn/

* lower barrier for contributors to get started

relax node version to be 12.0.0 or higher; will use node version found in `.node-version` in CI

* updates required after merging latest development

was getting type errors when building. recreating the `yarn.lock` file seemed to resolve the issue.

* hidden dep on a specific type version in server

made dep explicit and now it can build.

* update request to patched version

non-breaking changes to request was updated in server, but not everywhere else. It appears that transitive deps were using the 2.88.0 request version instead of the updated one for the server package.

* missing commit from previous commit/merge

* do not force a higher version of yarn than the default on circleci

* exclude e2e.js helper from stop-only command

* trying to bust node_modules cache.https://github.com/yarnpkg/yarn/issues/6412#issuecomment-537787740

* incorrect quotation tick placement

* fix: properly postinstall parse-domain

Do not explicitly script the shell invocation of a dependency's postinstall (parse-domain). The dependency's node_modules may not be where the package thinks they are and are not properly resolved.

It appears that postinstall will automatically be called when installing with yarn.

* run all CI stages

* fix win-appveyor-build.js

* Update CONTRIBUTING.md

Co-Authored-By: Zach Bloomquist <github@chary.us>

* Update CONTRIBUTING.md

Co-Authored-By: Zach Bloomquist <github@chary.us>

* Update CONTRIBUTING.md

Co-Authored-By: Zach Bloomquist <github@chary.us>

* Server package watching a specific test works correctly.

* PR feedback

* Correctly use yarn to pack (to get package size)

* correct size calculation

`yarn pack` does not output the file name like `npm pack` does. Correct this by explictly setting the filename.

* PR feedback

* PR feedback

* update readmes and testing commands from them

* do not include this in default build

* yarn is now installed by default

https://github.com/appveyor/ci/issues/1852

* do not include server in `yarn` auto build

* a few more npm references changed to yarn

* Revert "run all CI stages"

This reverts commit 9256aed99f.

* Update circle.yml

Co-Authored-By: Zach Bloomquist <github@chary.us>

Co-authored-by: Zach Bloomquist <github@chary.us>
2020-02-11 12:40:07 +06:30
Ryan Sherer
8f4137c2d2 Update ISSUE_TEMPLATE.md path inside CONTRIBUTING.md (#5962)
ISSUE 5926: Update ISSUE_TEMPLATE.md path inside CONTRIBUTING.md

Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
2019-12-23 13:45:09 +06:30
Josef Biehler
75befb05cf add hint for windows user to enable them to contribute, too, wi… (#5902)
* add hint for windows user to enable them to contribute, too, without too much workarounds

* adjust message

* add a little formatting, clean up wording


Co-authored-by: Zach Bloomquist <github@chary.us>
2019-12-19 13:13:55 +06:30
Santosh Yadav
932f859c31 docs: move contributing and code of conduct (#5881) 2019-12-06 23:31:35 +06:30