mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-02-04 10:25:17 -06:00
Code Issues Packages Projects Releases 126 Wiki Activity

Update maxJsonKeyLength to keep chunks below 48KB

Browse Source
This commit is contained in:
Nick Tobey
2025-01-08 12:45:36 -08:00
parent 83d858955d
commit 04af9a689b
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
go/store/prolly/tree/json_scanner.go
View File

@@ -41,9 +41,10 @@ type JsonScanner struct {
// The JSONChunker can't draw a chunk boundary within an object key.
// This can lead to large chunks that may cause problems.
// We've observed chunks getting written incorrectly if they exceed 48KB.
// Since boundaries are always drawn once a chunk exceeds maxChunkSize (16KB),
// this is the largest length that can be appended to a chunk without exceeding 1MB.
var maxJsonKeyLength = 1024*1024 - maxChunkSize
// this is the largest length that can be appended to a chunk without exceeding 48KB.
var maxJsonKeyLength = 48*1024 - maxChunkSize
var jsonParseError = fmt.Errorf("encountered invalid JSON while reading JSON from the database, or while preparing to write JSON to the database. This is most likely a bug in JSON diffing")
var largeJsonKeyError = errorkinds.NewKind("encountered JSON key with length %s, larger than max allowed length %s")