Removed skips for tests that will now work

This commit is contained in:
Daylon Wilkins
2019-09-12 10:28:25 -07:00
committed by Daylon Wilkins
parent ed5f6feddb
commit 18ddd88643
3 changed files with 11 additions and 9 deletions
+2 -4
View File
@@ -117,7 +117,6 @@ if rows[2] != "9,8,7,6,5,4".split(","):
}
@test "dolt sql all manner of inserts" {
skip "Temporary skip due to bug that needs to be tackled in go-mysql-server"
run dolt sql -q "insert into test (pk,c1,c2,c3,c4,c5) values (0,6,6,6,6,6)"
[ "$status" -eq 0 ]
[[ "$output" =~ "| 1 |" ]] || false
@@ -139,17 +138,16 @@ if rows[2] != "9,8,7,6,5,4".split(","):
[ "$output" = "column <pk> received nil but is non-nullable" ]
run dolt sql -q "insert into test (pk,c1,c2,c3,c4,c5,c6) values (10,1,1,1,1,1,1)"
[ "$status" -eq 1 ]
[ "$output" = "Error inserting rows: Unknown column: 'c6'" ]
[ "$output" = "invalid column name c6" ]
run dolt sql -q "insert into test (pk,c1,c2,c3,c4,c5) values (0,6,6,6,6,6)"
[ "$status" -eq 1 ]
[ "$output" = "duplicate primary key given" ] || false
}
@test "dolt sql insert same column twice" {
skip "Temporary skip due to bug that needs to be tackled in go-mysql-server"
run dolt sql -q "insert into test (pk,c1,c1) values (3,1,2)"
[ "$status" -eq 1 ]
[[ "$output" =~ "Repeated column" ]] || false
[ "$output" = "duplicate column name c1" ]
}
@test "dolt sql insert no columns specified" {
+1 -1
View File
@@ -57,7 +57,7 @@ require (
vitess.io/vitess v3.0.0-rc.3.0.20190602171040-12bfde34629c+incompatible
)
replace github.com/src-d/go-mysql-server => github.com/liquidata-inc/go-mysql-server v0.4.1-0.20190911213247-6dfc00bbb116
replace github.com/src-d/go-mysql-server => github.com/liquidata-inc/go-mysql-server v0.4.1-0.20190912171848-afe92c9129ca
replace vitess.io/vitess => github.com/liquidata-inc/vitess v0.0.0-20190625235908-66745781a796
@@ -106,10 +106,14 @@ var BasicInsertTests = []InsertTest{
ExpectedSchema: NewResultSetSchema("id", types.IntKind, "first", types.StringKind, "last", types.StringKind),
},
{
Name: "insert partial columns duplicate column",
InsertQuery: "insert into people (id, first, last, first) values (2, 'Bart', 'Simpson', 'Bart')",
ExpectedErr: "duplicate column",
SkipOnSqlEngine: true,
Name: "insert partial columns duplicate column",
InsertQuery: "insert into people (id, first, last, first) values (2, 'Bart', 'Simpson', 'Bart')",
ExpectedErr: "duplicate column",
},
{
Name: "insert partial columns invalid column",
InsertQuery: "insert into people (id, first, last, middle) values (2, 'Bart', 'Simpson', 'Nani')",
ExpectedErr: "duplicate column",
},
{
Name: "insert missing non-nullable column",