mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-01-05 16:15:41 -06:00
Code Issues Packages Projects Releases 115 Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Jason Fulghum <jason@dolthub.com>
This commit is contained in:
Nick Tobey
2025-02-24 19:31:51 -08:00
committed by GitHub
parent 3c2827704f
commit 4c3748c4e4
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
go/libraries/doltcore/schema/typecompatibility/type_compatibility.go
View File

@@ -41,7 +41,7 @@ type TypeCompatibilityChecker interface {
IsTypeChangeCompatible(from, to typeinfo.TypeInfo) TypeChangeInfo
}
// newTypeCompatabilityCheckerForStorageFormat returns a new TypeCompatibilityChecker
// NewTypeCompatabilityCheckerForStorageFormat returns a new TypeCompatibilityChecker
// instance for the given storage format.
func NewTypeCompatabilityCheckerForStorageFormat(format *storetypes.NomsBinFormat) TypeCompatibilityChecker {
switch format {

4
integration-tests/bats/schema-changes.bats
View File

@@ -445,8 +445,8 @@ EOF
env DOLT_TEST_ASSERT_NO_TABLE_REWRITE=1 dolt sql -q "alter table t modify column vc varchar(15);"
env DOLT_TEST_ASSERT_NO_TABLE_REWRITE=1 dolt sql -q "alter table t modify column vb varbinary(15);"
# Changing the collation doesn't require a table rewrite, but it does invalidate the secondary indexes.
# The GMS API doesn't currently less us separate the two, so currently this causes a table rewrite, but it doesn't have to.
# Changing the collation for a non-PK column doesn't require a table rewrite, but it does invalidate the secondary indexes.
# The GMS API doesn't currently let us separate the two, so currently this causes a table rewrite, but it doesn't have to.
# env DOLT_TEST_ASSERT_NO_TABLE_REWRITE=1 dolt sql -q "alter table t modify column vc varchar(15) collate utf8mb4_0900_ai_ci;"
# After all these schema changes, the table hash remains the same.