Added skipped test for dolt_diff() table function not respecting schema overrides

2026-02-05 10:31:30 -06:00 · 2026-01-06 09:09:53 -08:00
parent ed7ddc5871
commit 600958aa5d
1 changed files with 113 additions and 0 deletions
--- a/go/libraries/doltcore/sqle/enginetest/dolt_queries_schema_override.go
+++ b/go/libraries/doltcore/sqle/enginetest/dolt_queries_schema_override.go
@@ -1349,4 +1349,117 @@ var SchemaOverrideTests = []queries.ScriptTest{
 			},
 		},
 	},
+
+	// DOLT_DIFF() TABLE FUNCTION TEST CASE
+	{
+		Name: "dolt_diff() table function: schema overrides should apply to dolt_diff() table function",
+		Skip: true, // TODO: dolt_diff() table function does not respect schema overrides
+		SetUpScript: []string{
+			"create table t (pk int primary key, c1 varchar(255));",
+			"insert into t (pk, c1) values (1, 'one');",
+			"call dolt_commit('-Am', 'adding table t on main');",
+			"SET @commit1 = hashof('HEAD');",
+
+			"alter table t drop column c1;",
+			"call dolt_commit('-am', 'dropping column c1 on main');",
+			"SET @commit2 = hashof('HEAD');",
+
+			"alter table t add column c2 varchar(255);",
+			"insert into t (pk, c2) values (2, 'two');",
+			"call dolt_commit('-am', 'adding column c2 on main');",
+			"SET @commit3 = hashof('HEAD');",
+		},
+		Assertions: []queries.ScriptTestAssertion{
+			{
+				// use the first commit for our schema override (pk, c1)
+				Query:    "SET @@dolt_override_schema=@commit1;",
+				Expected: []sql.Row{{gmstypes.NewOkResult(0)}},
+			},
+			{
+				// sanity check that the schema override is working on regular tables
+				Query: "select * from t;",
+				Expected: []sql.Row{
+					{1, nil},
+					{2, nil},
+				},
+				ExpectedColumns: sql.Schema{
+					{
+						Name: "pk",
+						Type: gmstypes.Int32,
+					},
+					{
+						Name: "c1",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 255),
+					},
+				},
+			},
+			{
+				// dolt_diff() should respect schema override and show from_c1 and to_c1 columns
+				Query: "select from_pk, from_c1, to_pk, to_c1, diff_type from dolt_diff(@commit1, @commit3, 't');",
+				Expected: []sql.Row{
+					{nil, nil, 1, "one", "added"},
+					{1, "one", 1, nil, "modified"},
+					{nil, nil, 2, nil, "added"},
+				},
+				ExpectedColumns: sql.Schema{
+					{
+						Name: "from_pk",
+						Type: gmstypes.Int32,
+					},
+					{
+						Name: "from_c1",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 255),
+					},
+					{
+						Name: "to_pk",
+						Type: gmstypes.Int32,
+					},
+					{
+						Name: "to_c1",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 255),
+					},
+					{
+						Name: "diff_type",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 16),
+					},
+				},
+			},
+			{
+				// use the third commit for our schema override (pk, c2)
+				Query:    "SET @@dolt_override_schema=@commit3;",
+				Expected: []sql.Row{{gmstypes.NewOkResult(0)}},
+			},
+			{
+				// dolt_diff() should respect schema override and show from_c2 and to_c2 columns
+				Query: "select from_pk, from_c2, to_pk, to_c2, diff_type from dolt_diff(@commit1, @commit3, 't');",
+				Expected: []sql.Row{
+					{nil, nil, 1, nil, "added"},
+					{1, nil, 1, nil, "modified"},
+					{nil, nil, 2, "two", "added"},
+				},
+				ExpectedColumns: sql.Schema{
+					{
+						Name: "from_pk",
+						Type: gmstypes.Int32,
+					},
+					{
+						Name: "from_c2",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 255),
+					},
+					{
+						Name: "to_pk",
+						Type: gmstypes.Int32,
+					},
+					{
+						Name: "to_c2",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 255),
+					},
+					{
+						Name: "diff_type",
+						Type: gmstypes.MustCreateStringWithDefaults(sqltypes.VarChar, 16),
+					},
+				},
+			},
+		},
+	},
 }