mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2025-12-30 16:12:39 -06:00
Code Issues Packages Projects Releases 114 Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Jason Fulghum <jason@dolthub.com>
This commit is contained in:
Nick Tobey
2025-07-01 16:03:34 -07:00
committed by GitHub
parent d570c8b492
commit 67e0c9be21
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
go/libraries/doltcore/sqle/index/dolt_index.go
View File

@@ -218,7 +218,7 @@ func DoltToFromCommitIndexes(tbl string, sch schema.Schema) (indexes []sql.Index
order: sql.IndexOrderNone,
constrainedToLookupExpression: false,
// We pass a nil ValueStore into the key builder, because we don't have one. This would cause an issue
// if any of the columns uss Adaptive encoding, but that shouldn't be possible in the primary key.
// if any of the columns use Adaptive encoding, but that shouldn't be possible in the primary key.
keyBld: val.NewTupleBuilder(sch.GetKeyDescriptor(nil), nil),
})
}

1
integration-tests/bats/sql-commit-diff.bats
View File

@@ -80,7 +80,6 @@ teardown() {
run dolt sql -q "select from_pk1, from_pk2, to_pk1, to_pk2, diff_type from dolt_commit_diff_test_two_pk where from_commit = DOLT_HASHOF('initial') and to_commit = DOLT_HASHOF('update') and from_pk1 = 2;"
[ $status -eq 0 ]
echo "$output"
[[ "${#lines[@]}" = "6" ]] # 2 rows + 4 formatting lines
[[ "$output" =~ "| 2 | 21 | 2 | 21 | modified |" ]] || false
[[ "$output" =~ "| 2 | 20 | NULL | NULL | removed |" ]] || false