mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-02-23 10:08:58 -06:00
Code Issues Packages Projects Releases 136 Wiki Activity

Adding additional tests to cover various levels of grants (single table, multi-table, global/multi-db).

Browse Source
This commit is contained in:
Jason Fulghum
2022-03-28 14:40:14 -07:00
parent 8072998901
commit aeb834b60a
1 changed files with 73 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
go/libraries/doltcore/sqle/enginetest/dolt_queries.go
View File

@@ -108,21 +108,21 @@ var DoltUserPrivTests = []enginetest.UserPrivilegeTest{
},
Assertions: []enginetest.UserPrivilegeTestAssertion{
{
// Without access to the database, dolt_diff should fail
// Without access to the database, dolt_diff should fail with a database access error
User: "tester",
Host: "localhost",
Query: "SELECT * FROM dolt_diff('test', 'main~', 'main');",
ExpectedErr: sql.ErrDatabaseAccessDeniedForUser,
},
{
// Grant access to the underlying user table
// Grant single-table access to the underlying user table
User: "root",
Host: "localhost",
Query: "GRANT SELECT ON mydb.test TO tester@localhost;",
Expected: []sql.Row{{sql.NewOkResult(0)}},
},
{
// After granting access to `test`, dolt_diff should work
// After granting access to mydb.test, dolt_diff should work
User: "tester",
Host: "localhost",
Query: "SELECT COUNT(*) FROM dolt_diff('test', 'main~', 'main');",
@@ -135,6 +135,76 @@ var DoltUserPrivTests = []enginetest.UserPrivilegeTest{
Query: "SELECT * FROM dolt_diff('test2', 'main~', 'main');",
ExpectedErr: sql.ErrPrivilegeCheckFailed,
},
{
// Revoke select on mydb.test
User: "root",
Host: "localhost",
Query: "REVOKE SELECT ON mydb.test from tester@localhost;",
Expected: []sql.Row{{sql.NewOkResult(0)}},
},
{
// After revoking access, dolt_diff should fail
User: "tester",
Host: "localhost",
Query: "SELECT * FROM dolt_diff('test', 'main~', 'main');",
ExpectedErr: sql.ErrDatabaseAccessDeniedForUser,
},
{
// Grant multi-table access for all of mydb
User: "root",
Host: "localhost",
Query: "GRANT SELECT ON mydb.* to tester@localhost;",
Expected: []sql.Row{{sql.NewOkResult(0)}},
},
{
// After granting access to the entire db, dolt_diff should work
User: "tester",
Host: "localhost",
Query: "SELECT COUNT(*) FROM dolt_diff('test', 'main~', 'main');",
Expected: []sql.Row{{1}},
},
{
// Revoke multi-table access
User: "root",
Host: "localhost",
Query: "REVOKE SELECT ON mydb.* from tester@localhost;",
Expected: []sql.Row{{sql.NewOkResult(0)}},
},
{
// After revoking access, dolt_diff should fail
User: "tester",
Host: "localhost",
Query: "SELECT * FROM dolt_diff('test', 'main~', 'main');",
ExpectedErr: sql.ErrDatabaseAccessDeniedForUser,
},
{
// Grant global access to *.*
User: "root",
Host: "localhost",
Query: "GRANT SELECT ON *.* to tester@localhost;",
Expected: []sql.Row{{sql.NewOkResult(0)}},
},
{
// After granting global access to *.*, dolt_diff should work
User: "tester",
Host: "localhost",
Query: "SELECT COUNT(*) FROM dolt_diff('test', 'main~', 'main');",
Expected: []sql.Row{{1}},
},
{
// Revoke global access
User: "root",
Host: "localhost",
Query: "REVOKE ALL ON *.* from tester@localhost;",
Expected: []sql.Row{{sql.NewOkResult(0)}},
},
{
// After revoking global access, dolt_diff should fail
User: "tester",
Host: "localhost",
Query: "SELECT * FROM dolt_diff('test', 'main~', 'main');",
ExpectedErr: sql.ErrDatabaseAccessDeniedForUser,
},
},
},
}