mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-02-09 10:38:10 -06:00
Code Issues Packages Projects Releases 127 Wiki Activity

Another overflow issue in archive reader

Browse Source
This commit is contained in:
Neil Macneale IV
2025-06-30 11:54:28 -07:00
parent 7c16477b63
commit bfabd23803
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/store/nbs/archive_reader.go
View File

@@ -104,7 +104,7 @@ func (f archiveFooter) indexChunkRefSpan() byteSpan {
// indexSuffixSpan returns the span of the suffix section of the index. This is the fourth part of the index.
func (f archiveFooter) indexSuffixSpan() byteSpan {
suffixLen := uint64(f.chunkCount * hash.SuffixLen)
suffixLen := uint64(f.chunkCount) * hash.SuffixLen
chunkRefs := f.indexChunkRefSpan()
return byteSpan{chunkRefs.offset + chunkRefs.length, suffixLen}
}
@@ -231,7 +231,7 @@ func buildArchiveReader(ctx context.Context, reader tableReaderAt, footer archiv
suffixSpan := footer.indexSuffixSpan()
sufRdr := newSectionReader(ctx, reader, int64(suffixSpan.offset), int64(suffixSpan.length), stats)
suffixes := make([]byte, uint64(footer.chunkCount)*hash.SuffixLen)
suffixes := make([]byte, suffixSpan.length)
_, err = io.ReadFull(sufRdr, suffixes)
if err != nil {
return archiveReader{}, fmt.Errorf("Failed to read suffixes: %w", err)