Remove Dataset.Close()

We decided this API doesn't really make sense. So, remove it.

Fixes #932

clients/counter/counter.go

@@ -21,7 +21,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	lastVal := uint64(0)
 	if commit, ok := ds.MaybeHead(); ok {

clients/crunchbase/importer/importer.go

@@ -44,7 +44,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	fmt.Print("Fetching excel file - this can take a minute or so...")
 	resp, err := httpClient.Get(url)

clients/csv/importer/importer.go

@@ -37,7 +37,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	if flag.NArg() != 1 {
 		fmt.Printf("Expected exactly one parameter (path) after flags, but you have %d. Maybe you put a flag after the path?\n", flag.NArg())

clients/flickr/flickr.go

@@ -66,7 +66,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	api := liveFlickrAPI{}
 	getUser(api)

clients/json_importer/json_importer.go

@@ -19,7 +19,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	url := flag.Arg(0)
 	if ds == nil || url == "" {

clients/music/mp3_importer/mp3_importer.go

@@ -88,7 +88,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	if *addFlag != "" {
 		addMp3(ds, *addFlag)

clients/picasa/picasa.go

@@ -58,7 +58,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	var currentUser *User
 	if commit, ok := ds.MaybeHead(); ok {

clients/sfcrime/importer/sfcrime.go

@@ -64,7 +64,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	defer ds.Close()
+	defer ds.Store().Close()
 
 	csvfile, err := os.Open(*inputFlag)
 	if err != nil {

clients/shove/shove.go

@@ -32,7 +32,7 @@ func main() {
 		return
 	}
 	defer sourceStore.Close()
-	defer sink.Close()
+	defer sink.Store().Close()
 
 	err := d.Try(func() {
 		if util.MaybeStartCPUProfile() {

clients/tagdex/tagdex_test.go

@@ -57,7 +57,7 @@ func (s *testSuite) TestTagdex() {
 	var err error
 	inputDs, err = inputDs.Commit(refVal)
 	s.NoError(err)
-	inputDs.Close()
+	inputDs.Store().Close()
 
 	out := s.Run(main, []string{"-store", sn, "-in", "input-test", "-out", "tagdex-test"})
 	s.Contains(out, "Indexed 105 photos")

clients/xml_importer/xml_importer.go

@@ -55,7 +55,7 @@ func main() {
 			flag.Usage()
 			return
 		}
-		defer ds.Close()
+		defer ds.Store().Close()
 
 		if util.MaybeStartCPUProfile() {
 			defer util.StopCPUProfile()

dataset/dataset.go

@@ -107,10 +107,6 @@ func (ds *Dataset) SetNewHead(newHeadRef ref.Ref) (Dataset, error) {
 	return ds.CommitWithParents(commit.Value(), commit.Parents())
 }
 
-func (ds *Dataset) Close() {
-	ds.store.Close()
-}
-
 type datasetFlags struct {
 	datas.Flags
 	datasetID *string