mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-01-28 03:08:53 -06:00
Code Issues Packages Projects Releases 123 Wiki Activity

Comment fixes

Browse Source
This commit is contained in:
Taylor Bantle
2023-02-24 12:01:55 -08:00
parent 4bb204b8da
commit db4cbd1c75
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/libraries/doltcore/diff/table_deltas.go
View File

@@ -464,8 +464,8 @@ func (td TableDelta) GetSummary(ctx context.Context) (*TableDeltaSummary, error)
}, nil
}
// TODO: Modified columns (rename, add) without a data change are not
// accounted for here, `dataChanged` is true when it should be false
// TODO: Renamed columns without a data change are not accounted for here,
// `dataChanged` is true when it should be false
dataChanged, err := td.HasHashChanged()
if err != nil {
return nil, err

2
go/libraries/doltcore/sqle/enginetest/dolt_queries_diff.go
View File

@@ -2528,7 +2528,7 @@ var DiffSummaryTableFunctionScriptTests = []queries.ScriptTest{
},
{
Query: "SELECT * from dolt_diff_summary(@Commit3, @Commit4, 't');",
Expected: []sql.Row{{"t", "modified", true, true}}, // TODO: data change should be false for added column
Expected: []sql.Row{{"t", "modified", true, true}},
},
{
Query: "SELECT * from dolt_diff_summary(@Commit3, @Commit5, 't');",