mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-05-21 19:49:05 -05:00
Code Issues Packages Projects Releases 168 Wiki Activity

bug fix: correctly convert secondary to primary key lookups

Browse Source
This commit is contained in:
Zach Musgrave
2026-02-03 17:20:23 -08:00
parent 45982840c1
commit e2c8d79ce3
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
go/libraries/doltcore/merge/violations_fk_prolly.go
+6 -9
View File
@@ -67,10 +67,12 @@ func prollyParentSecDiffFkConstraintViolations(
childPrimary := &indexAndKeyDescriptor{
index: childPriIdx,
keyDesc: childPriIdxDesc,
schema: postChild.Schema,
}
childSecondary := &indexAndKeyDescriptor{
index: childSecIdx,
keyDesc: childSecIdxDesc,
schema: postChild.IndexSchema,
}
// We allow foreign keys between types that don't have the same serialization bytes for the same logical values
@@ -173,10 +175,12 @@ func prollyParentPriDiffFkConstraintViolations(
childPrimary := &indexAndKeyDescriptor{
index: childPriIdx,
keyDesc: childPriIdxDesc,
schema: postChild.Schema,
}
childSecondary := &indexAndKeyDescriptor{
index: childScndryIdx,
keyDesc: childSecIdxDesc,
schema: postChild.IndexSchema,
}
// We allow foreign keys between types that don't have the same serialization bytes for the same logical values
@@ -548,6 +552,7 @@ func makeOrdinalMappingForSchemas(from, to *schema.ColCollection) (m val.Ordinal
type indexAndKeyDescriptor struct {
index prolly.Map
keyDesc *val.TupleDesc
schema schema.Schema
}
// createCVsForDanglingChildRows finds all rows in the childIdx that match the given parent key and creates constraint
@@ -611,21 +616,13 @@ func createCVsForDanglingChildRows(
return err
}
kb := val.NewTupleBuilder(childPrimaryIdx.keyDesc, childPrimaryIdx.index.NodeStore())
for k, _, err := itr.Next(ctx); err != io.EOF; k, _, err = itr.Next(ctx) {
if err != nil {
return err
}
// convert secondary idx entry to primary row key
// the pks of the table are the last keys of the index
o := k.Count() - childPrimaryIdx.keyDesc.Count()
for i := 0; i < childPrimaryIdx.keyDesc.Count(); i++ {
j := o + i
kb.PutRaw(i, k.GetField(j))
}
primaryIdxKey, err := kb.Build(childPrimaryIdx.index.Pool())
primaryIdxKey, err := primaryKeyFromSecondaryIndexRow(k, childPrimaryIdx.keyDesc, childPrimaryIdx.index, childPrimaryIdx.schema, childSecIdx.schema)
if err != nil {
return err
}