Aaron Son
a9ea25e32c
go/cmd/dolt/commands/sqlserver: server.go: Lock the multienv repo before we init the sql server.
2023-11-15 10:29:07 -08:00
Aaron Son
58bd173904
go/cmd/dolt/commands/sqlserver: server.go: Change style to use named return for err in Init/Close lambdas.
2023-11-15 10:27:16 -08:00
Aaron Son
23dc3ed014
cmd/dolt/commands/sqlserver: Restructure the start up sequence for sql-server.
...
We explicitly model Services, which can have an Init step, a Run step and a
Stop step. Every registered service get initialized in the order they were
registered in, then they all run concurrently until Stop is called, when they
all get Stopped in reverse order. It's possible for clients to wait for init to
be completed and be delivered any errors encountered on startup. They can also
wait for stop, to be delivered any errors encountered on shutdown.
2023-11-14 16:58:55 -08:00
max-hoffman
0cc42b8440
[ga-bump-release] Update Dolt version to 1.26.1 and release v1.26.1
v1.26.1
2023-11-14 16:32:44 +00:00
Neil Macneale IV
fb0b896ad9
Print an error when server args don't validate ( #7003 )
2023-11-14 08:14:44 -08:00
Dustin Brown
bdea793e2a
[ga-bump-dep] Bump dependency in Dolt by max-hoffman ( #7002 )
...
Co-authored-by: max-hoffman <maximilian.wolfgang1@gmail.com >
2023-11-13 16:31:51 -08:00
Maximilian Hoffman
e0b2d36878
[no-release-notes]Stats bump ( #6997 )
...
* Get index statistics enginetests working w/ Dolt
* gms bump
* fix stats collecting, bump
* fix test build
2023-11-13 08:46:05 -08:00
Zach Musgrave
b903f78428
Merge pull request #6974 from dolthub/zachmu/virtual-merge
...
Support merging schemas with virtual / generated columns
2023-11-10 21:56:46 -08:00
Aaron Son
81ec91d11c
Merge pull request #6996 from dolthub/aaron/sqle-cluster-commithook-shutdown-deadlock-fix
...
go: sqle: cluster: commithook: When shutting down the server, the cluster replication commithook could deadlock after the replication thread missed a wakeup signal.
2023-11-10 17:27:58 -08:00
zachmu
27d4c05be5
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2023-11-11 00:32:49 +00:00
Zach Musgrave
d26755805e
Always use a new sql context when parsing schemas
2023-11-10 16:22:20 -08:00
Zach Musgrave
64ea7fe269
PR feedback
2023-11-10 15:54:03 -08:00
Zach Musgrave
83542cc84d
Fixed fast forward flag in test results
2023-11-10 15:23:46 -08:00
Zach Musgrave
3122380244
Used sql.Context in more places it made sense
2023-11-10 15:06:59 -08:00
Aaron Son
0913c5eb8c
integration-tests/go-sql-server-driver: sql-server-cluster-users-and-grants.yaml: branch_control_block_on_write_replication: Add an assertion on a connection to server2 after the branch control perms replicate, to ensure we don't send the TERM signal to the server process at the end of the test before it is fully started up.
2023-11-10 15:03:50 -08:00
Zach Musgrave
d7af14c4a3
Better assertions for merge calls
2023-11-10 14:56:35 -08:00
Aaron Son
038343ac96
go/libraries/doltcore/remotesrv: For the grpcSrv.Stop() call in the port multiplexed case, add a wait group and explicitly wait for requests to be finished for now.
...
The functionality where all request handler threads are cleaned up when Stop()
returns is not in the released version of grpc-go yet.
2023-11-10 14:27:17 -08:00
Aaron Son
5deea65347
go: sqle: cluster: commithook: When shutting down the server, the cluster replication commithook could deadlock after the replication thread missed a wakeup signal.
...
Fix it so that the wakeup thread is guaranteed to see the canceled context or
the wakeup signal.
2023-11-10 12:00:05 -08:00
Aaron Son
0fda70e4ea
Merge pull request #6993 from dolthub/aaron/atomic-write-utility
...
[no-release-notes] go/libraries/utils/file: Small refactor so attempts to do atomic file writes use a common helper method.
2023-11-10 11:18:53 -08:00
Aaron Son
037bf63d81
Merge pull request #6992 from dolthub/aaron/sql-server-cluster-cleanup
...
go/libraries/doltcore/remotesrv: Ensure we stop the gRPC server and cancel inflight requests when we are multiplexing one port for HTTP and gRPC traffic.
2023-11-10 10:20:33 -08:00
Aaron Son
faa0f91ba2
Fix for regression in relative base dir functionality of go/libraries/utils/filesys/localfs.go
2023-11-10 09:35:17 -08:00
Aaron Son
1dc224e325
[no-release-notes] go/libraries/utils/file: Small refactor so attempts to do atomic file writes use a common helper method.
2023-11-10 08:07:00 -08:00
Aaron Son
4decabd766
Merge remote-tracking branch 'origin/main' into aaron/sql-server-cluster-cleanup
2023-11-10 07:52:33 -08:00
Aaron Son
ce15b1f51e
PR feedback for remotesrv gRPC shutdown improvement.
2023-11-10 06:35:29 -08:00
Zach Musgrave
abb3b9ffc3
Merge upstream
2023-11-09 17:09:12 -08:00
Zach Musgrave
c52141602e
Bug fix for sql contexts with no current db. Also cleaned up a bit of useless code
2023-11-09 17:08:23 -08:00
zachmu
166553a87b
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2023-11-10 01:02:55 +00:00
Zach Musgrave
ace740508f
Cleared up import cycle in test
2023-11-09 16:53:00 -08:00
Zach Musgrave
5c00056f61
Changes from merging main
2023-11-09 16:39:50 -08:00
Aaron Son
dbab30cda3
Merge pull request #6977 from dolthub/aaron/mysqldb-atomic-file-write
...
Improve the persistence of the file that stores USERs and GRANTs.
2023-11-09 16:25:07 -08:00
Zach Musgrave
718c28d13a
Upgrade gms
2023-11-09 16:21:17 -08:00
Zach Musgrave
bfc39481b2
Merge branch 'main' into zachmu/virtual-merge
2023-11-09 16:19:27 -08:00
Zach Musgrave
5d5cdaffee
Re skip debug test
2023-11-09 16:19:11 -08:00
Zach Musgrave
3dbe3b1660
Skip a failing test
2023-11-09 16:18:05 -08:00
Zach Musgrave
8a9c4ee669
Skipped failing test
2023-11-09 16:17:07 -08:00
Aaron Son
d1ec1d5fc4
go/libraries/doltcore/remotesrv: Ensure we stop the gRPC server and cancel inflight requests when we are multiplexing one port for HTTP and gRPC traffic.
2023-11-09 15:54:37 -08:00
Zach Musgrave
1d15424624
Bug fix for iter construction
2023-11-09 15:51:15 -08:00
Zach Musgrave
0f66c5f718
Fix comment
2023-11-09 15:48:20 -08:00
Zach Musgrave
02078d32a2
Bug fix: need to make a row the length of the projections, not the length of physical columns
2023-11-09 15:28:09 -08:00
Jason Fulghum
684476834c
Merge pull request #6990 from dolthub/fulghum-734826ff
...
[auto-bump] [no-release-notes] dependency by fulghum
2023-11-09 15:06:11 -08:00
Jason Fulghum
de9d288b8d
Merge branch 'main' into fulghum-734826ff
2023-11-09 15:04:42 -08:00
Aaron Son
ce592c4ddc
go/libraries/doltcore/env: Close sql-server.lock file after we open it for read.
2023-11-09 14:54:09 -08:00
Aaron Son
28c9d47a8e
go/libraries/doltcore/dtestutils/sql_server_driver: Ensure we add server name prefix on output log lines even after a server restart in a test.
2023-11-09 14:47:55 -08:00
Aaron Son
8eeb38bf21
go/libraries/doltcore/dtestutils/sql_server_driver: Ensure we add server name prefix on output log lines even after a server restart in a test.
2023-11-09 14:47:34 -08:00
Aaron Son
41bcbb93f7
go: filesys: Take a FileMode on WriteFile. Fix sql-server.lock file handling to not leak file handles and keep correct perms when creating the file.
2023-11-09 14:35:28 -08:00
Aaron Son
2c46fdc5f0
Merge remote-tracking branch 'origin/aaron/mysqldb-atomic-file-write' into aaron/mysqldb-atomic-file-write
2023-11-09 14:23:52 -08:00
Aaron Son
d79bd8a8c2
Merge remote-tracking branch 'origin/main' into aaron/mysqldb-atomic-file-write
2023-11-09 14:18:09 -08:00
JCOR11599
9740fee3cf
[ga-bump-release] Update Dolt version to 1.26.0 and release v1.26.0
v1.26.0
2023-11-09 21:51:42 +00:00
Dustin Brown
8736fa7189
Merge pull request #6991 from dolthub/db/update-mysql-version
...
[no-release-notes] /.github/workflows: update mysql version
2023-11-09 13:48:50 -08:00
Jason Fulghum
39cf089169
Merge pull request #6988 from dolthub/fulghum-942e1760
...
[auto-bump] [no-release-notes] dependency by fulghum
2023-11-09 13:42:28 -08:00