Commit Graph

8683 Commits

Author SHA1 Message Date
Aaron Son
e84e4ab4eb Merge pull request #1477 from dolthub/aaron/bump-go-mysql-server
go/go.mod: Bump go-mysql-server.
2021-03-24 17:05:53 -07:00
Aaron Son
78f2435ef5 go/go.mod: Bump go-mysql-server. 2021-03-24 16:23:30 -07:00
Aaron Son
b8d15ce44e Merge pull request #1474 from dolthub/aaron/async-indexed-lookups-results-leak-fix
go/libraries/doltcore/sqle/async_indexed_lookups.go: Fix leaking of results from one index lookup to another.
2021-03-24 16:18:47 -07:00
Aaron Son
9b763af5a6 libraries/utils/async/ring_buffer.go: PR feedback. Return error on epoch mismatch. 2021-03-24 15:45:58 -07:00
Aaron Son
b77f2bad8c go/libraries/doltcore/sqle/async_indexed_lookups.go: Fix leaking of results from one index lookup to another.
When a query with an index lookup as a LIMIT, it's possible for the result
iterator to be closed before all the index results have been streamed. When
that happens, we can end up with queueRows goroutine which is enqueuing rows
into a ring buffer that is going to be used by a different query later.

This PR adds two mechanisms, one to stop the wrong results from being seen and
to cancel the unnecessary work.

1. RingBuffer gets an epoch, which is incremented on each Reset(). If a given
   Push does not match the current epoch, then nothing is added to the ring
   buffer.

2. queueRows is run with a cancelable (sub-)Context, and that Context is
   canceled when the corresponding iterator is Closed().
2021-03-24 14:11:09 -07:00
Brian Hendriks
daa3d27d8d panic fix for 0 rows resolved (#1471)
* fix panic that occurs when a delete query against a conflict table affects 0 rows

* bats test for 0 conflict delete

* formatting

* fixes
2021-03-23 14:16:31 -07:00
Zach Musgrave
5ad9bfe4e2 Update faq.md 2021-03-23 12:00:07 -07:00
Zach Musgrave
3515c42ae2 Update faq.md 2021-03-23 11:59:35 -07:00
Daylon Wilkins
7faa06a761 Bump gms 2021-03-22 23:01:13 -07:00
Zach Musgrave
59a799bb73 Merge pull request #1467 from dolthub/zachmu/active-branch
Bug fix for active_branch() function
2021-03-22 17:27:15 -07:00
Zach Musgrave
2c60c09503 Bug fix for active_branch() function 2021-03-22 16:24:47 -07:00
Tim Sehn
ded5318fe8 Changed Datasets to Clone to be more recent 2021-03-22 11:52:11 -07:00
Tim Sehn
e51f2c22c1 Update faq.md 2021-03-20 09:17:01 -07:00
Tim Sehn
b59bf058b0 Update Why call something Dolt is FAQ 2021-03-20 09:16:35 -07:00
Vinai Rachakonda
de8f4d9b3a Vinai/more dbeaver stuff (#1455)
This pr fixes a bug where cross db queries were not committing/allowed when the current database is not set. This allows for basic compatibility with dbeaver.
2021-03-19 14:01:26 -04:00
Zach Musgrave
265275adfd Merge pull request #1456 from alrs/store-marshal-errs
store/marshal: dropped error and test refactor
2021-03-19 09:42:32 -07:00
Zach Musgrave
c04dee2783 Merge pull request #1462 from dolthub/zachmu/select-aliases
New select expression behavior
2021-03-19 09:37:32 -07:00
Zach Musgrave
509fe7ccc5 Formatting 2021-03-18 18:43:18 -07:00
Zach Musgrave
4b54d181c1 Fixed broken test caused by changing group by behavior, for the case when a group by expression isn't in the select list. 2021-03-18 18:33:03 -07:00
Zach Musgrave
af826badbd Fixed test failure caused by new result set schema 2021-03-18 18:17:48 -07:00
Zach Musgrave
ceb7673b43 Fixed test failure caused by new result set schema 2021-03-18 18:07:34 -07:00
Zach Musgrave
c42d2548a5 Fixed test failure caused by new result set schema 2021-03-18 17:59:29 -07:00
Zach Musgrave
dd7c6744ab Fixed a broken test caused by SQL column change, unskipped a now working engine test 2021-03-18 17:19:50 -07:00
Tim Sehn
9b988523c1 Copy Edits to FAQ 2021-03-18 11:51:30 -07:00
Zach Musgrave
55738acae5 Update quickstart.md 2021-03-18 11:34:59 -07:00
Zach Musgrave
d014e1dabb Merge pull request #1461 from dolthub/tim/quickstart-edits
Tim's edits to quick start guide
2021-03-18 11:31:51 -07:00
Tim Sehn
33a7723c6b Tim's edits to quick start guide
Just edited the lead in to be a little more hype.
2021-03-18 11:31:03 -07:00
Brian Hendriks
3c463827f4 use left right diff instead of top down due to bugs in top down (#1457) 2021-03-18 10:53:33 -07:00
Zach Musgrave
05e316a8fa Update quickstart.md 2021-03-17 13:47:47 -07:00
Zach Musgrave
41bc3b6a0a Update quickstart.md 2021-03-17 13:45:28 -07:00
Zach Musgrave
cea9befd31 Merge pull request #1458 from dolthub/zachmu/docs
Docs expansion
2021-03-17 13:40:29 -07:00
Zach Musgrave
0be3ae5168 Added image files and moved files 2021-03-17 12:36:20 -07:00
Zach Musgrave
81df1c9d0a Expanded the docs and moved all but README out of the root dir 2021-03-17 12:34:42 -07:00
Daylon Wilkins
ff7bee1f9f Added DELIMITER support to batch input 2021-03-16 20:25:18 -07:00
Lars Lehtonen
73e1b8fa86 store/marshal: prune unused unmarshalNomsError 2021-03-16 19:57:55 -07:00
Lars Lehtonen
bf272b2d66 store/marshal: fix dropped error 2021-03-16 19:56:29 -07:00
Lars Lehtonen
099cae1829 store/marshal: replace assert.NoError with require.NoError in tests 2021-03-16 19:55:17 -07:00
Daylon Wilkins
0983c60c11 Added check to CI for bats test names 2021-03-16 18:17:02 -07:00
Vinai Rachakonda
a8336ffc1d Add table statistics functions for show table status (#1438)
Add statistics functions for show table status.
2021-03-16 17:50:19 -04:00
Vinai Rachakonda
0c1d7553ac Updates to error handling for unset configs. (#1444)
Co-authored-by: Lawrence Cook <lawrencescook@gmail.com>
2021-03-16 15:03:14 -04:00
Daylon Wilkins
ebf57383e9 Added limited self referential foreign key support 2021-03-16 02:48:55 -07:00
Tim Sehn
a42aa88057 Merge pull request #1449 from dolthub/tim/remove-samples
Remove samples
2021-03-15 18:40:16 -07:00
Tim Sehn
8b3f41e91b Update README.md 2021-03-15 18:12:03 -07:00
Tim Sehn
5899e4cb74 Merge branch 'master' of https://github.com/dolthub/dolt into tim/remove-samples 2021-03-15 17:54:43 -07:00
Dustin Brown
9b9cc87fb2 Merge pull request #1450 from dolthub/db/hide-dockerfiles
[no-release-notes] /:hide/delete dockerfiles
2021-03-15 17:25:31 -07:00
Dustin Brown
ff43f268f9 : hide/delete dockerfiles 2021-03-15 16:57:55 -07:00
Dustin Brown
22eca35ca0 Merge pull request #1451 from dolthub/db/fix-compatability
[no-release-notes] /.github/workflows/ci-compatibility-tests.yaml: fix working dir
2021-03-15 16:57:11 -07:00
Dustin Brown
a9b8dfea77 /.github/workflows/ci-compatibility-tests.yaml: fix working dir 2021-03-15 16:52:15 -07:00
Tim Sehn
50b1b74d64 Remove samples. We should make something more tested if we want something like this. 2021-03-15 16:31:34 -07:00
Dustin Brown
77b0ddd124 Merge pull request #1445 from dolthub/db/root-refactor
[no-release-notes] Db/root refactor
2021-03-15 16:01:39 -07:00