mirror/formbricks-formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2026-01-06 05:40:02 -06:00
Code Issues Packages Projects Releases 100 Wiki Activity

fix: recall issues (#2680)

Browse Source
This commit is contained in:
Dhruwang Jariwala
2024-05-23 12:24:54 +05:30
committed by GitHub
parent 27b37a5f27
commit 052f86b19f
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/lib/utils/recall.ts
View File

@@ -9,7 +9,7 @@ export interface fallbacks {
// Extracts the ID of recall question from a string containing the "recall" pattern.
export const extractId = (text: string): string | null => {
const pattern = /#recall:([A-Za-z0-9]+)/;
const pattern = /#recall:([A-Za-z0-9_-]+)/;
const match = text.match(pattern);
if (match && match[1]) {
return match[1];
@@ -20,7 +20,7 @@ export const extractId = (text: string): string | null => {
// If there are multiple recall infos in a string extracts all recall question IDs from that string and construct an array out of it.
export const extractIds = (text: string): string[] => {
const pattern = /#recall:([A-Za-z0-9]+)/g;
const pattern = /#recall:([A-Za-z0-9_-]+)/g;
const matches = Array.from(text.matchAll(pattern));
return matches.map((match) => match[1]).filter((id) => id !== null);
};
@@ -38,7 +38,7 @@ export const extractFallbackValue = (text: string): string => {
// Extracts the complete recall information (ID and fallback) from a headline string.
export const extractRecallInfo = (headline: string): string | null => {
const pattern = /#recall:([A-Za-z0-9]+)\/fallback:(\S*)#/;
const pattern = /#recall:([A-Za-z0-9_-]+)\/fallback:(\S*)#/;
const match = headline.match(pattern);
return match ? match[0] : null;
};
@@ -150,7 +150,7 @@ export const getRecallQuestions = (text: string, survey: TSurvey, langauge: stri
// Constructs a fallbacks object from a text containing multiple recall and fallback patterns.
export const getFallbackValues = (text: string): fallbacks => {
if (!text.includes("#recall:")) return {};
const pattern = /#recall:([A-Za-z0-9]+)\/fallback:([\S*]+)#/g;
const pattern = /#recall:([A-Za-z0-9_-]+)\/fallback:([\S*]+)#/g;
let match;
const fallbacks: fallbacks = {};

2
packages/ui/QuestionFormInput/components/RecallQuestionSelect.tsx
View File

@@ -117,7 +117,7 @@ export const RecallQuestionSelect = ({
}, [showQuestionSelect, localSurvey.questions, focusedQuestionIdx]);
return (
<div className="absolute z-30 mt-1 flex max-w-[85%] flex-col overflow-y-auto rounded-md border border-slate-300 bg-slate-50 p-3 text-xs ">
<div className="absolute z-30 mt-1 flex max-h-40 max-w-[85%] flex-col overflow-y-auto rounded-md border border-slate-300 bg-slate-50 p-3 text-xs ">
{filteredRecallQuestions.length === 0 ? (
<p className="font-medium text-slate-900">There is no information to recall yet 🤷</p>
) : (