mirror/formbricks-formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2026-01-06 05:40:02 -06:00
Code Issues Packages Projects Releases 100 Wiki Activity

chore: blacklisted questionIds (#1700)

Browse Source
This commit is contained in:
Dhruwang Jariwala
2023-11-29 16:21:31 +05:30
committed by GitHub
parent c35a57d2ca
commit 163732cea0
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/components/HiddenFieldsCard.tsx
View File

@@ -162,7 +162,10 @@ const validateHiddenField = (
return "Question already exists";
}
// no key words -- userId & suid & existing question ids
if (["userId", "suid"].includes(field) || existingQuestions.findIndex((q) => q.id === field) !== -1) {
if (
["userId", "source", "suid", "end", "start", "welcomeCard", "hidden"].includes(field) ||
existingQuestions.findIndex((q) => q.id === field) !== -1
) {
return "Question not allowed";
}
// no spaced words --> should be valid query param on url

4
apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/components/UpdateQuestionId.tsx
View File

@@ -40,10 +40,10 @@ export default function UpdateQuestionId({
updateQuestion(questionIdx, { id: prevValue });
toast.error("ID should not be empty.");
return;
} else if (currentValue === "source" || currentValue === "suID" || currentValue === "userId") {
} else if (["userId", "source", "suid", "end", "start", "welcomeCard", "hidden"].includes(currentValue)) {
setCurrentValue(prevValue);
updateQuestion(questionIdx, { id: prevValue });
toast.error("ID cannot used reserved words.");
toast.error("Reserved words cannot be used as question ID");
return;
} else {
setIsInputInvalid(false);