mirror/formbricks-formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2026-03-03 12:58:54 -06:00
Code Issues Packages Projects Releases 100 Wiki Activity

fix: user cannot select a skipped logic for a required question

Browse Source
This commit is contained in:
ShubhamPalriwala
2023-09-01 12:52:03 +05:30
parent cc9142e89b
commit 632bab40f3
2 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/LogicEditor.tsx
View File

@@ -239,18 +239,15 @@ export default function LogicEditor({
<SelectValue placeholder="Select condition" className="text-xs lg:text-sm" />
</SelectTrigger>
<SelectContent>
{conditions[question.type].map(
(condition) =>
!(question.required && condition === "skipped") && (
<SelectItem
key={condition}
value={condition}
title={logicConditions[condition].label}
className="text-xs lg:text-sm">
{logicConditions[condition].label}
</SelectItem>
)
)}
{conditions[question.type].map((condition) => (
<SelectItem
key={condition}
value={condition}
title={logicConditions[condition].label}
className="text-xs lg:text-sm">
{logicConditions[condition].label}
</SelectItem>
))}
</SelectContent>
</Select>

7
apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/SurveyMenuBar.tsx
View File

@@ -46,7 +46,7 @@ export default function SurveyMenuBar({
let faultyQuestions: String[] = [];
const existingLogicConditions = new Set();
useEffect(() => {
if (audiencePrompt && activeId === "settings") {
setAudiencePrompt(false);
@@ -119,6 +119,11 @@ export default function SurveyMenuBar({
for (const question of survey.questions) {
for (const logic of question.logic || []) {
if (question.required && logic.condition === "skipped") {
toast.error("User cannot skip a required question, please change the logic jump!");
return false;
}
const validFields = ["condition", "destination", "value"].filter(
(field) => logic[field] !== undefined
).length;