mirror/formbricks-formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2025-12-29 18:00:26 -06:00
Code Issues Packages Projects Releases 100 Wiki Activity

Move Telemetry events to services and limit events to surveyCreated and responseCreated (#719)

Browse Source
This commit is contained in:
Matti Nannt
2023-08-21 09:47:06 +02:00
committed by GitHub
parent 0e19044b7f
commit 754bdfbca7
6 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/web/app/api/v1/client/responses/route.ts
View File

@@ -6,7 +6,6 @@ import { capturePosthogEvent } from "@formbricks/lib/posthogServer";
import { createResponse } from "@formbricks/lib/services/response";
import { getSurvey } from "@formbricks/lib/services/survey";
import { getTeamDetails } from "@formbricks/lib/services/teamDetails";
import { captureTelemetry } from "@formbricks/lib/telemetry";
import { TResponse, TResponseInput, ZResponseInput } from "@formbricks/types/v1/responses";
import { NextResponse } from "next/server";
import { UAParser } from "ua-parser-js";
@@ -81,8 +80,6 @@ export async function POST(request: Request): Promise<NextResponse> {
});
}
captureTelemetry("response created");
if (teamDetails?.teamOwnerId) {
await capturePosthogEvent(teamDetails.teamOwnerId, "response created", teamDetails.teamId, {
surveyId: response.surveyId,

3
apps/web/pages/api/v1/client/environments/[environmentId]/sessions/index.ts
View File

@@ -1,7 +1,6 @@
import { createSession } from "@/lib/api/clientSession";
import { getSettings } from "@/lib/api/clientSettings";
import type { NextApiRequest, NextApiResponse } from "next";
import { captureTelemetry } from "@formbricks/lib/telemetry";
export default async function handle(req: NextApiRequest, res: NextApiResponse) {
const environmentId = req.query.environmentId?.toString();
@@ -26,8 +25,6 @@ export default async function handle(req: NextApiRequest, res: NextApiResponse)
const session = await createSession(personId);
const settings = await getSettings(environmentId, personId);
captureTelemetry("session created");
return res.json({ session, settings });
} catch (error) {
res.status(500).json({ message: error.message });

6
apps/web/pages/api/v1/environments/[environmentId]/surveys/[surveyId]/responses/[submissionId]/responsesNotes/index.ts
View File

@@ -1,8 +1,7 @@
import { captureTelemetry } from "@/../../packages/lib/telemetry";
import { hasEnvironmentAccess, getSessionUser } from "@/lib/api/apiHelper";
import { getSessionUser, hasEnvironmentAccess } from "@/lib/api/apiHelper";
import { responses } from "@/lib/api/response";
import { prisma } from "@formbricks/database";
import type { NextApiRequest, NextApiResponse } from "next";
import { responses } from "@/lib/api/response";
export default async function handle(req: NextApiRequest, res: NextApiResponse) {
const environmentId = req.query.environmentId?.toString();
@@ -75,7 +74,6 @@ export default async function handle(req: NextApiRequest, res: NextApiResponse)
};
const newResponseNote = await prisma.responseNote.create(responseNote);
captureTelemetry("responseNote created");
return res.json(newResponseNote);
}

8
apps/web/pages/api/v1/environments/[environmentId]/surveys/[surveyId]/responses/[submissionId]/tags/index.ts
View File

@@ -1,9 +1,8 @@
import { captureTelemetry } from "@/../../packages/lib/telemetry";
import { hasEnvironmentAccess, getSessionUser } from "@/lib/api/apiHelper";
import { prisma } from "@formbricks/database";
import type { NextApiRequest, NextApiResponse } from "next";
import { getSessionUser, hasEnvironmentAccess } from "@/lib/api/apiHelper";
import { responses } from "@/lib/api/response";
import { prisma } from "@formbricks/database";
import { Prisma } from "@prisma/client";
import type { NextApiRequest, NextApiResponse } from "next";
export default async function handle(req: NextApiRequest, res: NextApiResponse) {
const environmentId = req.query.environmentId?.toString();
@@ -77,7 +76,6 @@ export default async function handle(req: NextApiRequest, res: NextApiResponse)
return res.status(500).json({ message: "Internal Server Error" });
}
captureTelemetry(`tags retrieved for response ${responseId}`);
return res.json(tags);
}

4
apps/web/pages/api/v1/environments/[environmentId]/tags/index.ts
View File

@@ -1,5 +1,4 @@
import { captureTelemetry } from "@/../../packages/lib/telemetry";
import { hasEnvironmentAccess, getSessionUser } from "@/lib/api/apiHelper";
import { getSessionUser, hasEnvironmentAccess } from "@/lib/api/apiHelper";
import { prisma } from "@formbricks/database/src/client";
import { TTag } from "@formbricks/types/v1/tags";
import { Prisma } from "@prisma/client";
@@ -43,7 +42,6 @@ export default async function handle(req: NextApiRequest, res: NextApiResponse)
return res.status(500).json({ message: "Internal Server Error" });
}
captureTelemetry(`tags retrived for ${environmentId}`);
return res.json(tags);
}

2
packages/lib/services/response.ts
View File

@@ -7,6 +7,7 @@ import { Prisma } from "@prisma/client";
import { cache } from "react";
import "server-only";
import { getPerson, transformPrismaPerson } from "./person";
import { captureTelemetry } from "../telemetry";
const responseSelection = {
id: true,
@@ -97,6 +98,7 @@ export const getResponsesByPersonId = async (personId: string): Promise<Array<TR
};
export const createResponse = async (responseInput: Partial<TResponseInput>): Promise<TResponse> => {
captureTelemetry("response created");
try {
let person: TPerson | null = null;