mirror/formbricks-formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2025-12-29 18:00:26 -06:00
Code Issues Packages Projects Releases 100 Wiki Activity

fix

Browse Source
This commit is contained in:
pandeymangg
2025-08-21 18:04:50 +05:30
parent f8869e7522
commit b945900fbf
1 changed files with 1 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/storage/.cursor/rules/storage-package.md
View File

@@ -108,7 +108,7 @@ export const S3_ENDPOINT_URL = process.env.S3_ENDPOINT_URL;
export const S3_FORCE_PATH_STYLE = process.env.S3_FORCE_PATH_STYLE === "1";
export const S3_BUCKET_NAME = process.env.S3_BUCKET_NAME;
// ✅ Validate required environment variables
// ✅ Validate in a function (e.g., inside createS3ClientFromEnv)
if (!S3_ACCESS_KEY || !S3_SECRET_KEY || !S3_BUCKET_NAME || !S3_REGION) {
return err({
code: "s3_credentials_error",
@@ -534,29 +534,6 @@ const DOWNLOAD_URL_EXPIRY = 3600; // 1 hour for downloads
const LONG_EXPIRY = 86400 * 7; // 7 days - security risk
```
## Security Best Practices
### File Upload Validation
Always validate file uploads with appropriate conditions:
```typescript
// ✅ Comprehensive upload conditions
const conditions = [
["content-length-range", 0, maxSize || DEFAULT_MAX_SIZE],
["eq", "$Content-Type", contentType],
["starts-with", "$key", filePath], // Restrict upload path
];
// ✅ Validate content type
if (!ALLOWED_CONTENT_TYPES.includes(contentType)) {
return err({
code: "validation_error",
message: "Invalid content type",
});
}
```
### Error Message Safety
Don't expose sensitive information in error messages: