mirror/formbricks-formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2026-05-04 04:41:38 -05:00
Code Issues Packages Projects Releases 100 Wiki Activity

fix: survey validation thank you card (#2875)

Browse Source 
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
This commit is contained in:
Anshuman Pandey
2024-07-11 20:52:37 +05:30
committed by GitHub
parent 2fc78c9219
commit ec781969fa
1 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/types/surveys/types.ts
+22 -7
View File
@@ -25,7 +25,7 @@ export const ZSurveyThankYouCard = z.object({
headline: ZI18nString.optional(),
subheader: ZI18nString.optional(),
buttonLabel: ZI18nString.optional(),
buttonLink: z.string().url("Invalid button link in thank you card").optional(),
buttonLink: z.string().optional(),
imageUrl: z.string().optional(),
videoUrl: z.string().optional(),
});
@@ -614,7 +614,7 @@ export const ZSurvey = z
}
}
if (welcomeCard.html) {
if (welcomeCard.html && welcomeCard.html.default.trim() !== "") {
multiLangIssue = validateCardFieldsForAllLanguages(
"welcomeCardHtml",
welcomeCard.html,
@@ -626,7 +626,7 @@ export const ZSurvey = z
}
}
if (welcomeCard.buttonLabel) {
if (welcomeCard.buttonLabel && welcomeCard.buttonLabel.default.trim() !== "") {
multiLangIssue = validateCardFieldsForAllLanguages(
"buttonLabel",
welcomeCard.buttonLabel,
@@ -647,7 +647,7 @@ export const ZSurvey = z
ctx.addIssue(multiLangIssue);
}
if (question.subheader) {
if (question.subheader && question.subheader.default.trim() !== "") {
multiLangIssue = validateQuestionLabels("subheader", question.subheader, languages, questionIndex);
if (multiLangIssue) {
ctx.addIssue(multiLangIssue);
@@ -686,7 +686,11 @@ export const ZSurvey = z
}
if (question.type === TSurveyQuestionTypeEnum.OpenText) {
if (question.placeholder) {
if (
question.placeholder &&
question.placeholder[defaultLanguageCode].trim() !== "" &&
languages.length > 1
) {
multiLangIssue = validateQuestionLabels(
"placeholder",
question.placeholder,
@@ -900,7 +904,7 @@ export const ZSurvey = z
}
}
if (thankYouCard.subheader) {
if (thankYouCard.subheader && thankYouCard.subheader.default.trim() !== "") {
multiLangIssue = validateCardFieldsForAllLanguages(
"subheader",
thankYouCard.subheader,
@@ -913,7 +917,7 @@ export const ZSurvey = z
}
}
if (thankYouCard.buttonLabel) {
if (thankYouCard.buttonLabel && thankYouCard.buttonLabel.default.trim() !== "") {
multiLangIssue = validateCardFieldsForAllLanguages(
"thankYouCardButtonLabel",
thankYouCard.buttonLabel,
@@ -923,6 +927,17 @@ export const ZSurvey = z
if (multiLangIssue) {
ctx.addIssue(multiLangIssue);
}
if (thankYouCard.buttonLink) {
const parsedButtonLink = z.string().url().safeParse(thankYouCard.buttonLink);
if (!parsedButtonLink.success) {
ctx.addIssue({
code: z.ZodIssueCode.custom,
message: `Invalid URL for the button link in thank you card.`,
path: ["thankYouCard", "buttonLink"],
});
}
}
}
}
});