fix shuffle in ranking question

packages/ui/components/ShuffleOptionSelect
which is imported in MatrixQuestionForm, MultipleChoiceQuestionForm,
RankingQuestionForm

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/MatrixQuestionForm.tsx

@@ -7,6 +7,7 @@ import { TI18nString, TSurvey, TSurveyMatrixQuestion } from "@formbricks/types/s
 import { Button } from "@formbricks/ui/components/Button";
 import { Label } from "@formbricks/ui/components/Label";
 import { QuestionFormInput } from "@formbricks/ui/components/QuestionFormInput";
+import { ShuffleOptionSelect } from "@formbricks/ui/components/ShuffleOptionSelect";
 import { isLabelValidForAllLanguages } from "../lib/validation";
 
 interface MatrixQuestionFormProps {
@@ -78,6 +79,24 @@ export const MatrixQuestionForm = ({
     }
   };
 
+  const shuffleOptionsTypes = {
+    none: {
+      id: "none",
+      label: "Keep current order",
+      show: true,
+    },
+    all: {
+      id: "all",
+      label: "Randomize all",
+      show: true,
+    },
+    exceptLast: {
+      id: "exceptLast",
+      label: "Randomize all except last option",
+      show: true,
+    },
+  };
+
   return (
     <form>
       <QuestionFormInput
@@ -211,6 +230,14 @@ export const MatrixQuestionForm = ({
               <span>Add column</span>
             </Button>
           </div>
+          <div className="mt-3 flex flex-1 items-center justify-end gap-2">
+            <ShuffleOptionSelect
+              shuffleOptionsTypes={shuffleOptionsTypes}
+              questionIdx={questionIdx}
+              updateQuestion={updateQuestion}
+              shuffleOption={question.shuffleOption}
+            />
+          </div>
         </div>
       </div>
     </form>

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/MultipleChoiceQuestionForm.tsx

@@ -19,13 +19,7 @@ import {
 import { Button } from "@formbricks/ui/components/Button";
 import { Label } from "@formbricks/ui/components/Label";
 import { QuestionFormInput } from "@formbricks/ui/components/QuestionFormInput";
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from "@formbricks/ui/components/Select";
+import { ShuffleOptionSelect } from "@formbricks/ui/components/ShuffleOptionSelect";
 import { QuestionOptionChoice } from "./QuestionOptionChoice";
 
 interface OpenQuestionFormProps {
@@ -290,29 +284,12 @@ export const MultipleChoiceQuestionForm = ({
             </Button>
 
             <div className="flex flex-1 items-center justify-end gap-2">
-              <Select
-                defaultValue={question.shuffleOption}
-                value={question.shuffleOption}
-                onValueChange={(e: TShuffleOption) => {
-                  updateQuestion(questionIdx, { shuffleOption: e });
-                }}>
-                <SelectTrigger className="w-fit space-x-2 overflow-hidden border-0 font-medium text-slate-600">
-                  <SelectValue placeholder="Select ordering" />
-                </SelectTrigger>
-                <SelectContent>
-                  {Object.values(shuffleOptionsTypes).map(
-                    (shuffleOptionsType) =>
-                      shuffleOptionsType.show && (
-                        <SelectItem
-                          key={shuffleOptionsType.id}
-                          value={shuffleOptionsType.id}
-                          title={shuffleOptionsType.label}>
-                          {shuffleOptionsType.label}
-                        </SelectItem>
-                      )
-                  )}
-                </SelectContent>
-              </Select>
+              <ShuffleOptionSelect
+                questionIdx={questionIdx}
+                shuffleOption={question.shuffleOption}
+                updateQuestion={updateQuestion}
+                shuffleOptionsTypes={shuffleOptionsTypes}
+              />
             </div>
           </div>
         </div>

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/RankingQuestionForm.tsx

@@ -7,22 +7,11 @@ import { PlusIcon } from "lucide-react";
 import { useEffect, useRef, useState } from "react";
 import { createI18nString, extractLanguageCodes } from "@formbricks/lib/i18n/utils";
 import { TAttributeClass } from "@formbricks/types/attribute-classes";
-import {
-  TI18nString,
-  TShuffleOption,
-  TSurvey,
-  TSurveyRankingQuestion,
-} from "@formbricks/types/surveys/types";
+import { TI18nString, TSurvey, TSurveyRankingQuestion } from "@formbricks/types/surveys/types";
 import { Button } from "@formbricks/ui/components/Button";
 import { Label } from "@formbricks/ui/components/Label";
 import { QuestionFormInput } from "@formbricks/ui/components/QuestionFormInput";
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from "@formbricks/ui/components/Select";
+import { ShuffleOptionSelect } from "@formbricks/ui/components/ShuffleOptionSelect";
 import { QuestionOptionChoice } from "./QuestionOptionChoice";
 
 interface RankingQuestionFormProps {
@@ -227,29 +216,12 @@ export const RankingQuestionForm = ({
               onClick={() => addOption()}>
               Add option
             </Button>
-            <Select
-              defaultValue={question.shuffleOption}
-              value={question.shuffleOption}
-              onValueChange={(option: TShuffleOption) => {
-                updateQuestion(questionIdx, { shuffleOption: option });
-              }}>
-              <SelectTrigger className="w-fit space-x-2 overflow-hidden border-0 font-medium text-slate-600">
-                <SelectValue placeholder="Select ordering" />
-              </SelectTrigger>
-              <SelectContent>
-                {Object.values(shuffleOptionsTypes).map(
-                  (shuffleOptionsType) =>
-                    shuffleOptionsType.show && (
-                      <SelectItem
-                        key={shuffleOptionsType.id}
-                        value={shuffleOptionsType.id}
-                        title={shuffleOptionsType.label}>
-                        {shuffleOptionsType.label}
-                      </SelectItem>
-                    )
-                )}
-              </SelectContent>
-            </Select>
+            <ShuffleOptionSelect
+              shuffleOptionsTypes={shuffleOptionsTypes}
+              updateQuestion={updateQuestion}
+              shuffleOption={question.shuffleOption}
+              questionIdx={questionIdx}
+            />
           </div>
         </div>
       </div>

packages/surveys/src/components/questions/MatrixQuestion.tsx

@@ -5,6 +5,7 @@ import { QuestionMedia } from "@/components/general/QuestionMedia";
 import { Subheader } from "@/components/general/Subheader";
 import { ScrollableContainer } from "@/components/wrappers/ScrollableContainer";
 import { getUpdatedTtc, useTtc } from "@/lib/ttc";
+import { getShuffledRowIndices } from "@/lib/utils";
 import { JSX } from "preact";
 import { useCallback, useMemo, useState } from "preact/hooks";
 import { getLocalizedValue } from "@formbricks/lib/i18n/utils";
@@ -42,6 +43,27 @@ export const MatrixQuestion = ({
   const isMediaAvailable = question.imageUrl || question.videoUrl;
   useTtc(question.id, ttc, setTtc, startTime, setStartTime, question.id === currentQuestionId);
 
+  const rowShuffleIdx = useMemo(() => {
+    if (question.shuffleOption) {
+      return getShuffledRowIndices(question.rows.length, question.shuffleOption);
+    } else {
+      return question.rows.map((_, id) => id);
+    }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [question.shuffleOption, question.rows.length]);
+
+  const questionRows = useMemo(() => {
+    if (!question.rows) {
+      return [];
+    }
+    if (question.shuffleOption === "none" || question.shuffleOption === undefined) {
+      return question.rows;
+    }
+    return rowShuffleIdx.map((shuffledIdx) => {
+      return question.rows[shuffledIdx];
+    });
+  }, [question.shuffleOption, question.rows, rowShuffleIdx]);
+
   const handleSelect = useCallback(
     (column: string, row: string) => {
       let responseValue =
@@ -116,7 +138,7 @@ export const MatrixQuestion = ({
                 </tr>
               </thead>
               <tbody>
-                {question.rows.map((row, rowIndex) => (
+                {questionRows.map((row, rowIndex) => (
                   // Table rows
                   <tr className={`${rowIndex % 2 === 0 ? "bg-input-bg" : ""}`}>
                     <td

packages/surveys/src/components/questions/RankingQuestion.tsx

@@ -5,7 +5,7 @@ import { QuestionMedia } from "@/components/general/QuestionMedia";
 import { Subheader } from "@/components/general/Subheader";
 import { ScrollableContainer } from "@/components/wrappers/ScrollableContainer";
 import { getUpdatedTtc, useTtc } from "@/lib/ttc";
-import { cn } from "@/lib/utils";
+import { cn, getShuffledChoicesIds } from "@/lib/utils";
 import { useAutoAnimate } from "@formkit/auto-animate/react";
 import { useCallback, useMemo, useState } from "preact/hooks";
 import { getLocalizedValue } from "@formbricks/lib/i18n/utils";
@@ -48,9 +48,18 @@ export const RankingQuestion = ({
       .filter((item): item is TSurveyQuestionChoice => item !== undefined)
   );
 
-  const [unsortedItems, setUnsortedItems] = useState<TSurveyQuestionChoice[]>(
-    question.choices.filter((c) => !value.includes(c.id))
-  );
+  const [unsortedItems, setUnsortedItems] = useState<TSurveyQuestionChoice[]>(() => {
+    if (!question.shuffleOption || question.shuffleOption === "none" || sortedItems.length > 1) {
+      // Return unshuffled items
+      return question.choices.filter((c) => !value.includes(c.id));
+    } else {
+      // Shuffle options
+      const shuffledChoiceIds = getShuffledChoicesIds(question.choices, question.shuffleOption);
+      return shuffledChoiceIds
+        .map((choiceId) => question.choices.find((choice) => choice.id === choiceId))
+        .filter((choice) => choice !== undefined);
+    }
+  });
 
   const [parent] = useAutoAnimate();
 

packages/surveys/src/lib/utils.ts

@@ -1,4 +1,5 @@
 import {
+  TShuffleOption,
   TSurvey,
   TSurveyLogic,
   TSurveyLogicAction,
@@ -17,7 +18,26 @@ const shuffle = (array: any[]) => {
   }
 };
 
-export const getShuffledChoicesIds = (choices: TSurveyQuestionChoice[], shuffleOption: string): string[] => {
+export const getShuffledRowIndices = (n: number, shuffleOption: TShuffleOption): number[] => {
+  // Create an array with numbers from 0 to n-1
+  let array = Array.from(Array(n).keys());
+
+  if (shuffleOption === "all") {
+    shuffle(array);
+  } else if (shuffleOption === "exceptLast") {
+    const lastElement = array.pop();
+    if (lastElement) {
+      shuffle(array);
+      array.push(lastElement);
+    }
+  }
+  return array;
+};
+
+export const getShuffledChoicesIds = (
+  choices: TSurveyQuestionChoice[],
+  shuffleOption: TShuffleOption
+): string[] => {
   const otherOption = choices.find((choice) => {
     return choice.id === "other";
   });

packages/types/surveys/types.ts

@@ -573,6 +573,7 @@ export const ZSurveyMatrixQuestion = ZSurveyQuestionBase.extend({
   type: z.literal(TSurveyQuestionTypeEnum.Matrix),
   rows: z.array(ZI18nString),
   columns: z.array(ZI18nString),
+  shuffleOption: ZShuffleOption.optional().default("none"),
 });
 
 export type TSurveyMatrixQuestion = z.infer<typeof ZSurveyMatrixQuestion>;

packages/ui/components/ShuffleOptionSelect/index.tsx

@@ -0,0 +1,62 @@
+import {
+  TShuffleOption,
+  TSurveyMatrixQuestion,
+  TSurveyMultipleChoiceQuestion,
+  TSurveyRankingQuestion,
+} from "@formbricks/types/surveys/types";
+import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "../Select";
+
+interface ShuffleOptionType {
+  id: string;
+  label: string;
+  show: boolean;
+}
+
+interface ShuffleOptionsTypes {
+  none?: ShuffleOptionType;
+  all?: ShuffleOptionType;
+  exceptLast?: ShuffleOptionType;
+}
+
+interface ShuffleOptionSelectProps {
+  shuffleOption: TShuffleOption | undefined;
+  updateQuestion: (
+    questionIdx: number,
+    updatedAttributes: Partial<TSurveyMatrixQuestion | TSurveyMultipleChoiceQuestion | TSurveyRankingQuestion>
+  ) => void;
+  questionIdx: number;
+  shuffleOptionsTypes: ShuffleOptionsTypes;
+}
+
+export const ShuffleOptionSelect: React.FC<ShuffleOptionSelectProps> = ({
+  questionIdx,
+  shuffleOption,
+  updateQuestion,
+  shuffleOptionsTypes,
+}) => {
+  return (
+    <Select
+      defaultValue={shuffleOption}
+      value={shuffleOption}
+      onValueChange={(e: TShuffleOption) => {
+        updateQuestion(questionIdx, { shuffleOption: e });
+      }}>
+      <SelectTrigger className="w-fit space-x-2 overflow-hidden border-0 font-medium text-slate-600">
+        <SelectValue placeholder="Select ordering" />
+      </SelectTrigger>
+      <SelectContent>
+        {Object.values(shuffleOptionsTypes).map(
+          (shuffleOptionsType) =>
+            shuffleOptionsType.show && (
+              <SelectItem
+                key={shuffleOptionsType.id}
+                value={shuffleOptionsType.id}
+                title={shuffleOptionsType.label}>
+                {shuffleOptionsType.label}
+              </SelectItem>
+            )
+        )}
+      </SelectContent>
+    </Select>
+  );
+};