fix: ensure survey.endings is always an array to prevent TypeError

Fixes FORMBRICKS-JE

- Added default empty array for survey.endings in transformPrismaSurvey
- Added defensive checks in progress-bar component and utils
- Fixed migration to handle null endings
- Prevents 'TypeError: e is not iterable' when survey.endings is null/undefined

apps/web/lib/survey/utils.ts

@@ -30,6 +30,7 @@ export const transformPrismaSurvey = <T extends TSurvey | TJsEnvironmentStateSur
     displayPercentage: Number(surveyPrisma.displayPercentage) || null,
     segment,
     customHeadScriptsMode: surveyPrisma.customHeadScriptsMode,
+    endings: surveyPrisma.endings || [],
   } as T;
 
   return transformedSurvey;

packages/database/migration/20251208033316_remove_empty_image_and_video_urls_from_elements/migration.ts

@@ -62,7 +62,7 @@ export const removeEmptyImageAndVideoUrlsFromElements: MigrationScript = {
           delete cleanedWelcomeCard.videoUrl;
         }
 
-        const cleanedEndings = survey.endings.map((ending) => {
+        const cleanedEndings = (survey.endings || []).map((ending) => {
           const cleanedEnding = { ...ending };
           if (cleanedEnding.imageUrl === "") {
             delete cleanedEnding.imageUrl;

packages/surveys/src/components/general/progress-bar.tsx

@@ -13,7 +13,7 @@ export function ProgressBar({ survey, blockId }: ProgressBarProps) {
     [survey.blocks, blockId]
   );
 
-  const endingCardIds = useMemo(() => survey.endings.map((ending) => ending.id), [survey.endings]);
+  const endingCardIds = useMemo(() => (survey.endings || []).map((ending) => ending.id), [survey.endings]);
 
   const calculateProgress = useCallback(
     (blockIndex: number) => {

packages/surveys/src/lib/utils.ts

@@ -87,7 +87,7 @@ export const calculateElementIdx = (
   const currentQuestion = questions[currentQustionIdx];
   const middleIdx = Math.floor(totalCards / 2);
   const possibleNextBlockIds = getPossibleNextBlocks(survey.blocks, currentQuestion);
-  const endingCardIds = survey.endings.map((ending) => ending.id);
+  const endingCardIds = (survey.endings || []).map((ending) => ending.id);
 
   // Convert block IDs to element IDs (get first element of each block)
   const possibleNextQuestionIds = possibleNextBlockIds