mirror/keycloak
1
0
Fork 0
mirror of https://github.com/keycloak/keycloak.git synced 2026-02-11 17:59:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Reorder operations to avoid the slow operation to get all client sessions

Browse Source 
Closes #39665

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
This commit is contained in:
Alexander Schwartz
2025-05-13 16:54:32 +02:00
committed by GitHub
parent 3e51c71ce8
commit a7985c175b
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
services/src/main/java/org/keycloak/authentication/AuthenticationProcessor.java
View File

@@ -1162,13 +1162,20 @@ public class AuthenticationProcessor {
event.detail(Details.REMEMBER_ME, "true");
}
final int clientSessions = userSession.getAuthenticatedClientSessions().size();
ClientSessionContext clientSessionCtx = TokenManager.attachAuthenticationSession(session, userSession, authSession);
if (clientSessions == 0 && userSession.getStarted() == userSession.getLastSessionRefresh()
&& TokenUtil.hasScope(clientSessionCtx.getScopeString(), OAuth2Constants.OFFLINE_ACCESS)) {
// user session is just created, empty and the first access was for offline token, set the note
clientSessionCtx.getClientSession().setNote(FIRST_OFFLINE_ACCESS, Boolean.TRUE.toString());
ClientSessionContext clientSessionCtx;
if (userSession.getStarted() == userSession.getLastSessionRefresh()) {
// calling getAuthenticatedClientSessions() will pull all client sessions and is therefore expensive.
// The nested ifs try to avoid the common case when the session already exists for some time and this is then called.
final int clientSessions = userSession.getAuthenticatedClientSessions().size();
clientSessionCtx = TokenManager.attachAuthenticationSession(session, userSession, authSession);
if (clientSessions == 0 && TokenUtil.hasScope(clientSessionCtx.getScopeString(), OAuth2Constants.OFFLINE_ACCESS)) {
// user session is just created, empty and the first access was for offline token, set the note
clientSessionCtx.getClientSession().setNote(FIRST_OFFLINE_ACCESS, Boolean.TRUE.toString());
} else {
clientSessionCtx.getClientSession().removeNote(FIRST_OFFLINE_ACCESS);
}
} else {
clientSessionCtx = TokenManager.attachAuthenticationSession(session, userSession, authSession);
clientSessionCtx.getClientSession().removeNote(FIRST_OFFLINE_ACCESS);
}