mirror/munki
1
0
Fork 0
mirror of https://github.com/munki/munki.git synced 2026-01-06 06:29:56 -06:00
Code Issues Packages Projects Releases Wiki Activity

More updated comments

Browse Source
This commit is contained in:
Greg Neagle
2025-06-08 19:56:34 -07:00
parent 112e0a74a4
commit 84ba6fa5ff
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
code/cli/munki/shared/utils/fileutils.swift
View File

@@ -223,17 +223,17 @@ func verifyExecutableOwnershipAndPermissions() -> Bool {
return true
}
/// Why not use FileManager.DirectoryEnumerator?
/// IOW, why not use FileManager.default.enumerator(atPath path: String)?
/// Why not use Foundation's FileManager.DirectoryEnumerator?
/// Why drop to POSIX calls like opendir, readdir, closedir, lstat, and stat?
///
/// A recursive list of files built via FileManager.DirectoryEnumerator is in a very different order than one built
/// with Python's os.walk(), making it difficult to prove that (for example), the output of `makecatalogs` is
/// with Python's os.walk(), making it difficult to prove that (for example), the result of `makecatalogs` is
/// the same from the Swift version as it is from the Python version.
///
/// Also, Munki expects to follow directory symlinks, which FileManager.DirectoryEnumerator does not.
///
/// Building a recursive list of file using FileManager.DirectoryEnumerator is much slower (5x-20x) than
/// the equivlent Python code based on os.walk(). This code is much closer, speed-wise.
/// Finally, building a recursive list of files using FileManager.DirectoryEnumerator is much slower (5x-20x) than
/// the equivalent Python code based on os.walk(). This implementation is essentially the same, speed-wise.
///
/// Returns a list of filepaths, relative to `top`.
/// Inspired by code here: https://forums.fast.ai/t/fast-file-enumeration-in-swift/44709/1