mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-07 04:40:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

graph: Turn PatchEducationSchool test into test table

Browse Source
This commit is contained in:
Ralf Haferkamp
2023-07-06 17:24:53 +02:00
committed by Ralf Haferkamp
parent 5304184bd6
commit 0bc36f1cf5
1 changed files with 27 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
services/graph/pkg/service/v0/educationschools_test.go
View File

@@ -288,58 +288,34 @@ var _ = Describe("Schools", func() {
Expect(rr.Code).To(Equal(http.StatusCreated))
})
})
Describe("PatchEducationSchool", func() {
It("handles invalid body", func() {
r := httptest.NewRequest(http.MethodPatch, "/graph/v1.0/education/schools/", bytes.NewBufferString("{invalid"))
rctx := chi.NewRouteContext()
rctx.URLParams.Add("schoolID", *newSchool.Id)
r = r.WithContext(context.WithValue(ctxpkg.ContextSetUser(ctx, currentUser), chi.RouteCtxKey, rctx))
svc.PatchEducationSchool(rr, r)
Expect(rr.Code).To(Equal(http.StatusBadRequest))
})
It("handles missing or empty school id", func() {
r := httptest.NewRequest(http.MethodPatch, "/graph/v1.0/education/schools", nil)
svc.PatchEducationSchool(rr, r)
Expect(rr.Code).To(Equal(http.StatusBadRequest))
r = httptest.NewRequest(http.MethodPatch, "/graph/v1.0/education/schools", nil)
rctx := chi.NewRouteContext()
rctx.URLParams.Add("schoolID", "")
r = r.WithContext(context.WithValue(ctxpkg.ContextSetUser(ctx, currentUser), chi.RouteCtxKey, rctx))
svc.PatchEducationSchool(rr, r)
Expect(rr.Code).To(Equal(http.StatusBadRequest))
})
It("handles malformed school id", func() {
r := httptest.NewRequest(http.MethodPatch, "/graph/v1.0/education/schools", nil)
rctx := chi.NewRouteContext()
rctx.URLParams.Add("schoolID", "school%id")
r = r.WithContext(context.WithValue(ctxpkg.ContextSetUser(ctx, currentUser), chi.RouteCtxKey, rctx))
svc.PatchEducationSchool(rr, r)
Expect(rr.Code).To(Equal(http.StatusBadRequest))
})
It("updates the school", func() {
newSchool = libregraph.NewEducationSchool()
newSchool.SetDisplayName("New School Name")
newSchoolJson, err := json.Marshal(newSchool)
Expect(err).ToNot(HaveOccurred())
identityEducationBackend.On("UpdateEducationSchool", mock.Anything, mock.Anything, mock.Anything).Return(newSchool, nil)
r := httptest.NewRequest(http.MethodPatch, "/graph/v1.0/education/schools/schoolid", bytes.NewBuffer(newSchoolJson))
rctx := chi.NewRouteContext()
rctx.URLParams.Add("schoolID", "school-id")
r = r.WithContext(context.WithValue(ctxpkg.ContextSetUser(ctx, currentUser), chi.RouteCtxKey, rctx))
svc.PatchEducationSchool(rr, r)
Expect(rr.Code).To(Equal(http.StatusOK))
Describe("updating a School", func() {
schoolUpdate := libregraph.NewEducationSchool()
schoolUpdate.SetDisplayName("New School Name")
schoolUpdateJson, _ := json.Marshal(schoolUpdate)
BeforeEach(func() {
identityEducationBackend.On("UpdateEducationSchool", mock.Anything, mock.Anything, mock.Anything).Return(schoolUpdate, nil)
})
DescribeTable("PatchEducationSchool",
func(schoolId string, body io.Reader, statusCode int) {
r := httptest.NewRequest(http.MethodPatch, "/graph/v1.0/education/schools/", body)
rctx := chi.NewRouteContext()
if schoolId != "" {
rctx.URLParams.Add("schoolID", schoolId)
}
r = r.WithContext(context.WithValue(ctxpkg.ContextSetUser(ctx, currentUser), chi.RouteCtxKey, rctx))
svc.PatchEducationSchool(rr, r)
Expect(rr.Code).To(Equal(statusCode))
},
Entry("handles invalid body", "school-id", bytes.NewBufferString("{invalid"), http.StatusBadRequest),
Entry("handles missing or empty school id", "", bytes.NewBufferString(""), http.StatusBadRequest),
Entry("handles malformed school id", "school%id", bytes.NewBuffer(schoolUpdateJson), http.StatusBadRequest),
Entry("updates the school", "school-id", bytes.NewBuffer(schoolUpdateJson), http.StatusOK),
)
})
Describe("DeleteEducationSchool", func() {