mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-06 20:29:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: return 404 code if file isn't found on CheckFileInfo request

Browse Source
This commit is contained in:
Juan Pablo Villafáñez
2024-09-19 10:51:28 +02:00
parent fddad3780d
commit 153502189d
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/collaboration/pkg/connector/fileconnector.go
View File

@@ -1058,6 +1058,10 @@ func (f *FileConnector) CheckFileInfo(ctx context.Context) (*ConnectorResponse,
Str("StatusCode", statRes.GetStatus().GetCode().String()).
Str("StatusMsg", statRes.GetStatus().GetMessage()).
Msg("CheckFileInfo: stat failed with unexpected status")
if statRes.GetStatus().GetCode() == rpcv1beta1.Code_CODE_NOT_FOUND {
return NewResponse(404), nil
}
return NewResponse(500), nil
}

13
services/collaboration/pkg/connector/fileconnector_test.go
View File

@@ -1634,6 +1634,19 @@ var _ = Describe("FileConnector", func() {
Expect(response.Body).To(BeNil())
})
It("Stat fails status not found", func() {
ctx := middleware.WopiContextToCtx(context.Background(), wopiCtx)
gatewayClient.On("Stat", mock.Anything, mock.Anything).Times(1).Return(&providerv1beta1.StatResponse{
Status: status.NewNotFound(ctx, "something not found"),
}, nil)
response, err := fc.CheckFileInfo(ctx)
Expect(err).ToNot(HaveOccurred())
Expect(response.Status).To(Equal(404))
Expect(response.Body).To(BeNil())
})
It("Stat success", func() {
ctx := middleware.WopiContextToCtx(context.Background(), wopiCtx)
u := &userv1beta1.User{