Refactor feature files to add proper description

2026-01-10 06:10:05 -06:00 · 2023-04-25 17:18:06 +05:45
parent 4076bc71e6
commit 4d98c24392
15 changed files with 48 additions and 6 deletions
--- a/tests/acceptance/features/coreApiAuth/webDavAuth.feature
+++ b/tests/acceptance/features/coreApiAuth/webDavAuth.feature
@@ -1,5 +1,8 @@
@api
 Feature: auth
+  As a user
+  I want to check the authentication of the application
+  So that I can make sure it's secure

  Background:
    Given user "Alice" has been created with default attributes and without skeleton files
--- a/tests/acceptance/features/coreApiAuthOcs/ocsDELETEAuth.feature
+++ b/tests/acceptance/features/coreApiAuthOcs/ocsDELETEAuth.feature
@@ -1,5 +1,8 @@
@api @files_sharing-app-required
 Feature: auth
+  As a user
+  I want to send delete request with wrong password
+  So that I can make sure it doesn't work

  Background:
    Given user "another-admin" has been created with default attributes and without skeleton files
--- a/tests/acceptance/features/coreApiAuthOcs/ocsGETAuth.feature
+++ b/tests/acceptance/features/coreApiAuthOcs/ocsGETAuth.feature
@@ -1,5 +1,8 @@
@api @files_sharing-app-required
 Feature: auth
+  As a user
+  I want to send GET request to various endpoints
+  So that I can make sure the endpoints need proper authentication

  Background:
    Given user "Alice" has been created with default attributes and without skeleton files
@@ -101,7 +104,7 @@ Feature: auth
    And the OCS status code of responses on all endpoints should be "200"

  @issue-1319
-  Scenario:using OCS with admin basic auth
+  Scenario: using OCS with admin basic auth
    When the administrator requests these endpoint with "GET"
      | endpoint                 |
      | /ocs/v1.php/cloud/apps   |
--- a/tests/acceptance/features/coreApiAuthOcs/ocsPOSTAuth.feature
+++ b/tests/acceptance/features/coreApiAuthOcs/ocsPOSTAuth.feature
@@ -1,5 +1,8 @@
@api @files_sharing-app-required
 Feature: auth
+  As a user
+  I want to send POST request to various endpoints
+  So that I can make sure the endpoints need proper authentication

  Background:
    Given user "Alice" has been created with default attributes and without skeleton files
--- a/tests/acceptance/features/coreApiAuthOcs/ocsPUTAuth.feature
+++ b/tests/acceptance/features/coreApiAuthOcs/ocsPUTAuth.feature
@@ -1,5 +1,8 @@
@api @files_sharing-app-required
 Feature: auth
+  As a user
+  I want to send PUT request to various endpoints
+  So that I can make sure the endpoints need proper authentication

  Background:
    Given user "another-admin" has been created with default attributes and without skeleton files
@@ -21,7 +24,7 @@ Feature: auth
    And the OCS status code of responses on all endpoints should be "997"


-  Scenario: Request to edit nonexistent user by authorized admin gets unauthorized in http response
+  Scenario: request to edit nonexistent user by authorized admin gets unauthorized in http response
    Given user "another-admin" has been added to group "admin"
    When user "another-admin" requests these endpoints with "PUT" including body "doesnotmatter" about user "nonexistent"
      | endpoint                                         |
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavCOPYAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavCOPYAuth.feature
@@ -1,6 +1,5 @@
@api
 Feature: COPY file/folder
-
  As a user
  I want to copy a file or folder
  So that I can duplicate it
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavDELETEAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavDELETEAuth.feature
@@ -1,5 +1,8 @@
@api
 Feature: delete file/folder
+  As a user
+  I want to delete a file or folder
+  So that I can remove redundant resources

  Background:
    Given these users have been created with default attributes and without skeleton files:
@@ -33,6 +36,7 @@ Feature: delete file/folder
      | /remote.php/dav/spaces/%spaceid%/PARENT/parent.txt |
    Then the HTTP status code of responses on all endpoints should be "401"

+
  Scenario: send DELETE requests to webDav endpoints as normal user with no password
    When user "Alice" requests these endpoints with "DELETE" using password "" about user "Alice"
      | endpoint                                           |
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavLOCKAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavLOCKAuth.feature
@@ -1,5 +1,8 @@
@api
 Feature: LOCK file/folder
+  As a user
+  I want to lock a file or folder
+  So that I can ensure that the resources won't be changed without authentication

  Background:
    Given these users have been created with default attributes and without skeleton files:
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavMKCOLAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavMKCOLAuth.feature
@@ -1,5 +1,8 @@
@api
 Feature: create folder using MKCOL
+  As a user 
+  I want to create folders
+  So that I can organise resources in folders

  Background:
    Given user "Alice" has been created with default attributes and without skeleton files
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavMOVEAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavMOVEAuth.feature
@@ -1,5 +1,8 @@
@api
 Feature: MOVE file/folder
+  As a user 
+  I want to move resources
+  So that I can organise resources according to my preference 

  Background:
    Given these users have been created with default attributes and without skeleton files:
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavPOSTAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavPOSTAuth.feature
@@ -1,5 +1,8 @@
@api
-Feature: get file info using POST
+Feature: POST file/folder
+  As a user
+  I want to send POST request to various endpoints
+  So that I can ensure the endpoints are well authenticated

  Background:
    Given these users have been created with default attributes and without skeleton files:
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavPROPFINDAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavPROPFINDAuth.feature
@@ -1,5 +1,8 @@
@api
-Feature: get file info using PROPFIND
+Feature: PROPFIND file/folder
+  As a user
+  I want to send PROPFIND request to various endpoints
+  So that I can ensure the endpoints are well authenticated

  Background:
    Given these users have been created with default attributes and without skeleton files:
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavPROPPATCHAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavPROPPATCHAuth.feature
@@ -1,5 +1,8 @@
@api
 Feature: PROPPATCH file/folder
+  As a user
+  I want to send PROPPATCH request to various endpoints
+  So that I can ensure the endpoints are well authenticated

  Background:
    Given these users have been created with default attributes and without skeleton files:
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavPUTAuth.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavPUTAuth.feature
@@ -1,5 +1,8 @@
@api
-Feature: get file info using PUT
+Feature: PUT file/folder
+  As a user
+  I want to send PUT request to various endpoints
+  So that I can ensure the endpoints are well authenticated

  Background:
    Given these users have been created with default attributes and without skeleton files:
--- a/tests/acceptance/features/coreApiAuthWebDav/webDavSpecialURLs.feature
+++ b/tests/acceptance/features/coreApiAuthWebDav/webDavSpecialURLs.feature
@@ -1,5 +1,8 @@
@api @skipOnOcV10.10.0
 Feature: make webdav request with special urls
+  As a user
+  I want to make webdav request with special urls
+  So that I can make sure that they work

  Background:
    Given user "Alice" has been created with default attributes and without skeleton files