set correct flag type (#76)

merging because the failing tests are unrelated
This commit is contained in:
David Christofas
2020-02-11 16:15:16 +01:00
committed by GitHub
parent 2b2e7f05c5
commit ac3381e277
3 changed files with 12 additions and 4 deletions
+8
View File
@@ -0,0 +1,8 @@
Bugfix: set correct flag type in the flagsets
While upgrading to the micro/cli version 2 there where two instances of `StringFlag`
which had not been changed to `StringSliceFlag`.
This caused `ocis-reva users` and `ocis-reva storage-root` to fail on startup.
https://github.com/owncloud/ocis-reva/issues/75
https://github.com/owncloud/ocis-reva/pull/76
+2 -2
View File
@@ -116,9 +116,9 @@ func StorageRootWithConfig(cfg *config.Config) []cli.Flag {
EnvVars: []string{"REVA_STORAGE_ROOT_URL"},
Destination: &cfg.Reva.StorageRoot.URL,
},
&cli.StringFlag{
&cli.StringSliceFlag{
Name: "service",
Value: "storageprovider",
Value: cli.NewStringSlice("storageprovider"),
Usage: "--service storageprovider [--service otherservice]",
EnvVars: []string{"REVA_STORAGE_ROOT_SERVICES"},
},
+2 -2
View File
@@ -195,9 +195,9 @@ func UsersWithConfig(cfg *config.Config) []cli.Flag {
EnvVars: []string{"REVA_USERS_URL"},
Destination: &cfg.Reva.Users.URL,
},
&cli.StringFlag{
&cli.StringSliceFlag{
Name: "service",
Value: "userprovider", // TODO preferences
Value: cli.NewStringSlice("userprovider"), // TODO preferences
Usage: "--service userprovider [--service otherservice]",
EnvVars: []string{"REVA_USERS_SERVICES"},
},