mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-04 11:19:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Select Available role only while sharing space

Browse Source
This commit is contained in:
sagargurung1001@gmail.com
2022-08-11 10:02:27 +05:45
parent 18996ea42a
commit c41cf352cd
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/acceptance/features/apiSpaces/copySpaces.feature
View File

@@ -437,7 +437,7 @@ Feature: copy file
Scenario Outline: User copies a folder from space shares jail with different role to space project with role viewer
Given the administrator has given "Brian" the role "Space Admin" using the settings api
And user "Brian" has created a space "Project" with the default quota using the GraphApi
And user "Brian" has shared a space "Project" to user "Alice" with role "<role>"
And user "Brian" has shared a space "Project" to user "Alice" with role "viewer"
And user "Brian" has created folder "/testshare"
And user "Brian" has created folder "/testshare/folder1"
And user "Brian" has uploaded file with content "testshare content" to "/testshare/folder1/testshare.txt"
@@ -450,4 +450,4 @@ Feature: copy file
Examples:
| permissions |
| 31 |
| 17 |
| 17 |

2
tests/acceptance/features/apiSpaces/moveSpaces.feature
View File

@@ -33,7 +33,7 @@ Feature: move (rename) file
And user "Brian" has created a space "Project" with the default quota using the GraphApi
And user "Brian" has created a folder "newfolder" in space "Project"
And user "Brian" has uploaded a file inside space "Project" with content "some content" to "insideSpace.txt"
And user "Brian" has shared a space "Project" to user "Alice" with role "<role>"
And user "Brian" has shared a space "Project" to user "Alice" with role "viewer"
When user "Alice" moves file "insideSpace.txt" to "newfolder/insideSpace.txt" in space "Project" using the WebDAV API
Then the HTTP status code should be "403"
And for user "Alice" the space "Project" should not contain these entries:

6
tests/acceptance/features/bootstrap/SpacesContext.php
View File

@@ -1989,6 +1989,10 @@ class SpacesContext implements Context {
string $role
): void {
$space = $this->getSpaceByName($user, $spaceName);
$availableRoleToAssignToShareSpace = ['manager', 'editor', 'viewer'];
if (!\in_array(\strtolower($role), $availableRoleToAssignToShareSpace)) {
throw new Error("The Selected " . $role . " Cannot be Found");
}
$body = [
"space_ref" => $space['id'],
"shareType" => 7,
@@ -1997,7 +2001,6 @@ class SpacesContext implements Context {
];
$fullUrl = $this->baseUrl . $this->ocsApiUrl;
$this->featureContext->setResponse(
$this->sendPostRequestToUrl(
$fullUrl,
@@ -2111,7 +2114,6 @@ class SpacesContext implements Context {
string $role
): void {
$this->sendShareSpaceRequest($user, $spaceName, $userRecipient, $role);
$expectedHTTPStatus = "200";
$this->featureContext->theHTTPStatusCodeShouldBe(
$expectedHTTPStatus,