mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-15 08:41:19 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(graph/ocm): Fix ocm share creation when user is in cache

Browse Source 
Federated users are sharing the cache with regular users. So can't
we need to check the user type to determine if the user is federated.

Fixes #10488
This commit is contained in:
Ralf Haferkamp
2024-11-07 16:50:52 +01:00
parent 28a0c9a98f
commit c463559ee7
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/graph/pkg/service/v0/api_driveitem_permissions.go
View File

@@ -168,11 +168,9 @@ func (s DriveItemPermissionsService) Invite(ctx context.Context, resourceId *sto
shareid = createShareResponse.GetShare().GetId().GetOpaqueId()
expiration = createShareResponse.GetShare().GetExpiration()
default:
federated := false
user, err := s.identityCache.GetUser(ctx, objectID)
if errors.Is(err, identity.ErrNotFound) && s.config.IncludeOCMSharees {
user, err = s.identityCache.GetAcceptedUser(ctx, objectID)
federated = true
if err == nil && IsSpaceRoot(statResponse.GetInfo().GetId()) {
return libregraph.Permission{}, errorcode.New(errorcode.InvalidRequest, "federated user can not become a space member")
}
@@ -189,7 +187,7 @@ func (s DriveItemPermissionsService) Invite(ctx context.Context, resourceId *sto
},
}
if federated {
if user.GetUserType() == identity.UserTypeFederated {
if len(user.Identities) < 1 {
return libregraph.Permission{}, errorcode.New(errorcode.InvalidRequest, "user has no federated identity")
}