mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-22 12:30:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6618 from kobergj/MoreRoleAssignerFixing

Browse Source 
Fix OIDC Role Assigning
This commit is contained in:
kobergj
2023-06-26 10:44:51 +02:00
committed by GitHub
parent 05137f1d17 1bf28dac43
commit d0e1adccf7
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelog/unreleased/fix-oidc-role-assigner.md
View File

@@ -5,3 +5,4 @@ This makes no sense as the user is supposed to have only one and the update will
We still log an error level log to make the admin aware of that.
https://github.com/owncloud/ocis/pull/6605
https://github.com/owncloud/ocis/pull/6618

2
services/proxy/pkg/userroles/oidcroles.go
View File

@@ -93,7 +93,7 @@ func (ra oidcRoleAssigner) UpdateUserRoleAssignment(ctx context.Context, user *c
}
logger.Debug().Interface("assignedRoleIds", assignedRoles).Msg("Currently assigned roles")
if len(assignedRoles) == 0 || (assignedRoles[0] != roleIDFromClaim) {
if len(assignedRoles) != 1 || (assignedRoles[0] != roleIDFromClaim) {
logger.Debug().Interface("assignedRoleIds", assignedRoles).Interface("newRoleId", roleIDFromClaim).Msg("Updating role assignment for user")
newctx, err := ra.prepareAdminContext()
if err != nil {