mirror/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-04-30 06:29:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

perf: Add missing indexes (#7425)

Browse Source 
* perf: Add missing indexes to notifications table

* Add two more missing indexes

* tests
This commit is contained in:
Tom Moor
2024-08-20 20:44:06 -04:00
committed by GitHub
parent 058e413a6e
commit 18d4eaee07
5 changed files with 65 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/migrations/20240821001616-add-notifications-index.js
+12
View File
@@ -0,0 +1,12 @@
'use strict';
/** @type {import('sequelize-cli').Migration} */
module.exports = {
async up (queryInterface, Sequelize) {
await queryInterface.addIndex('notifications', ['teamId', 'userId']);
},
async down (queryInterface, Sequelize) {
await queryInterface.removeIndex('notifications', ['teamId', 'userId']);
}
};
server/migrations/20240821002344-add-user-permission-index.js
+12
View File
@@ -0,0 +1,12 @@
'use strict';
/** @type {import('sequelize-cli').Migration} */
module.exports = {
async up (queryInterface, Sequelize) {
await queryInterface.addIndex('user_permissions', ['documentId', 'userId']);
},
async down (queryInterface, Sequelize) {
await queryInterface.removeIndex('user_permissions', ['documentId', 'userId']);
}
};
server/migrations/20240821002502-add-user-authentication-index.js
+12
View File
@@ -0,0 +1,12 @@
'use strict';
/** @type {import('sequelize-cli').Migration} */
module.exports = {
async up (queryInterface, Sequelize) {
await queryInterface.addIndex('user_authentications', ['userId']);
},
async down (queryInterface, Sequelize) {
await queryInterface.removeIndex('user_authentications', ['userId']);
}
};
server/routes/api/notifications/notifications.test.ts
+27
View File
@@ -32,6 +32,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
teamId: user.teamId,
userId: user.id,
viewedAt: new Date(),
archivedAt: new Date(),
@@ -41,6 +42,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.CreateComment,
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -48,6 +50,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -95,6 +98,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -102,6 +106,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.CreateComment,
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -109,6 +114,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -156,6 +162,7 @@ describe("#notifications.list", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -164,6 +171,7 @@ describe("#notifications.list", () => {
collectionId: collection.id,
event: NotificationEventType.CreateComment,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -171,6 +179,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -219,6 +228,7 @@ describe("#notifications.list", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -227,6 +237,7 @@ describe("#notifications.list", () => {
collectionId: collection.id,
event: NotificationEventType.CreateComment,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -234,6 +245,7 @@ describe("#notifications.list", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -365,6 +377,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
viewedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -372,6 +385,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.CreateComment,
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -379,6 +393,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -415,6 +430,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
viewedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -422,6 +438,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.CreateComment,
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -429,6 +446,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -466,6 +484,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
viewedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -474,6 +493,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.CreateComment,
viewedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -481,6 +501,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -518,6 +539,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -525,6 +547,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.CreateComment,
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -532,6 +555,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
@@ -569,6 +593,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.UpdateDocument,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -577,6 +602,7 @@ describe("#notifications.update_all", () => {
collectionId: collection.id,
event: NotificationEventType.CreateComment,
archivedAt: new Date(),
teamId: user.teamId,
userId: user.id,
}),
buildNotification({
@@ -584,6 +610,7 @@ describe("#notifications.update_all", () => {
documentId: document.id,
collectionId: collection.id,
event: NotificationEventType.MentionedInComment,
teamId: user.teamId,
userId: user.id,
}),
]);
server/routes/api/notifications/notifications.ts
+2
View File
@@ -76,6 +76,7 @@ router.post(
const { eventType, archived } = ctx.input.body;
const user = ctx.state.auth.user;
let where: WhereOptions<Notification> = {
teamId: user.teamId,
userId: user.id,
};
if (eventType) {
@@ -190,6 +191,7 @@ router.post(
const values: { [x: string]: any } = {};
let where: WhereOptions<Notification> = {
teamId: user.teamId,
userId: user.id,
};
if (!isUndefined(viewedAt)) {