mirror/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-05-04 06:59:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

[WEB-3944] fix: Error Toast message content update while uploading images (#6969)

Browse Source 
* fix: handled svg uploads

* chore: proper error message with all allowed types

---------

Co-authored-by: sangeethailango <sangeethailango21@gmail.com>
This commit is contained in:
Akshita Goyal
2025-04-25 14:30:12 +05:30
committed by GitHub
parent f60f57ef11
commit 101994840a
3 changed files with 25 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apiserver/plane/app/views/asset/v2.py
+3 -3
View File
@@ -137,7 +137,7 @@ class UserAssetsV2Endpoint(BaseAPIView):
if type not in allowed_types:
return Response(
{
"error": "Invalid file type. Only JPEG and PNG files are allowed.",
"error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False,
},
status=status.HTTP_400_BAD_REQUEST,
@@ -351,7 +351,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView):
if type not in allowed_types:
return Response(
{
"error": "Invalid file type. Only JPEG and PNG files are allowed.",
"error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False,
},
status=status.HTTP_400_BAD_REQUEST,
@@ -552,7 +552,7 @@ class ProjectAssetEndpoint(BaseAPIView):
if type not in allowed_types:
return Response(
{
"error": "Invalid file type. Only JPEG and PNG files are allowed.",
"error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False,
},
status=status.HTTP_400_BAD_REQUEST,
apiserver/plane/space/views/asset.py
+1 -1
View File
@@ -96,7 +96,7 @@ class EntityAssetEndpoint(BaseAPIView):
if type not in allowed_types:
return Response(
{
"error": "Invalid file type. Only JPEG and PNG files are allowed.",
"error": "Invalid file type. Only JPEG, PNG, WebP, JPG and GIF files are allowed.",
"status": False,
},
status=status.HTTP_400_BAD_REQUEST,
web/core/components/core/image-picker-popover.tsx
+21 -3
View File
@@ -14,7 +14,7 @@ import { useOutsideClickDetector } from "@plane/hooks";
// plane types
import { EFileAssetType } from "@plane/types/src/enums";
// ui
import { Button, Input, Loader } from "@plane/ui";
import { Button, Input, Loader, TOAST_TYPE, setToast } from "@plane/ui";
// helpers
import { getFileURL } from "@/helpers/file.helper";
// hooks
@@ -114,7 +114,16 @@ export const ImagePickerPopover: React.FC<Props> = observer((props) => {
},
image
)
.then((res) => uploadCallback(res.asset_url));
.then((res) => uploadCallback(res.asset_url))
.catch((error) => {
console.error("Error uploading user cover image:", error);
setIsImageUploading(false);
setToast({
message: error?.error ?? "The image could not be uploaded",
type: TOAST_TYPE.ERROR,
title: "Image not uploaded",
});
});
} else {
if (!workspaceSlug) return;
await fileService
@@ -126,7 +135,16 @@ export const ImagePickerPopover: React.FC<Props> = observer((props) => {
},
image
)
.then((res) => uploadCallback(res.asset_url));
.then((res) => uploadCallback(res.asset_url))
.catch((error) => {
console.error("Error uploading project cover image:", error);
setIsImageUploading(false);
setToast({
message: error?.error ?? "The image could not be uploaded",
type: TOAST_TYPE.ERROR,
title: "Image not uploaded",
});
});
}
};