mirror/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-01-30 10:23:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

[WIKI-556] fix : invert tracking logic #7668

Browse Source
This commit is contained in:
Vipin Chaudhary
2025-08-28 20:37:20 +05:30
committed by GitHub
parent e144ce8cf2
commit 7a43137620
3 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/api/plane/app/views/page/base.py
View File

@@ -198,7 +198,7 @@ class PageViewSet(BaseViewSet):
def retrieve(self, request, slug, project_id, pk=None):
page = self.get_queryset().filter(pk=pk).first()
project = Project.objects.get(pk=project_id)
track_visit = request.query_params.get("track_visit", "false").lower() == "true"
track_visit = request.query_params.get("track_visit", "true").lower() == "true"
"""
if the role is guest and guest_view_all_features is false and owned by is not

5
apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx
View File

@@ -58,10 +58,7 @@ const PageDetailsPage = observer(() => {
const { error: pageDetailsError } = useSWR(
workspaceSlug && projectId && pageId ? `PAGE_DETAILS_${pageId}` : null,
workspaceSlug && projectId && pageId
? () =>
fetchPageDetails(workspaceSlug?.toString(), projectId?.toString(), pageId.toString(), {
trackVisit: true,
})
? () => fetchPageDetails(workspaceSlug?.toString(), projectId?.toString(), pageId.toString())
: null,
{
revalidateIfStale: true,

13
apps/web/core/store/pages/project-page.store.ts
View File

@@ -53,7 +53,7 @@ export interface IProjectPageStore {
workspaceSlug: string,
projectId: string,
pageId: string,
{ trackVisit }: { trackVisit: boolean }
options?: { trackVisit?: boolean }
) => Promise<TPage | undefined>;
createPage: (pageData: Partial<TPage>) => Promise<TPage | undefined>;
removePage: (pageId: string) => Promise<void>;
@@ -244,12 +244,9 @@ export class ProjectPageStore implements IProjectPageStore {
* @description fetch the details of a page
* @param {string} pageId
*/
fetchPageDetails = async (
workspaceSlug: string,
projectId: string,
pageId: string,
{ trackVisit }: { trackVisit: boolean }
) => {
fetchPageDetails = async (...args: Parameters<IProjectPageStore["fetchPageDetails"]>) => {
const [workspaceSlug, projectId, pageId, options] = args;
const { trackVisit } = options || {};
try {
if (!workspaceSlug || !projectId || !pageId) return undefined;
@@ -259,7 +256,7 @@ export class ProjectPageStore implements IProjectPageStore {
this.error = undefined;
});
const page = await this.service.fetchById(workspaceSlug, projectId, pageId, trackVisit);
const page = await this.service.fetchById(workspaceSlug, projectId, pageId, trackVisit ?? true);
runInAction(() => {
if (page?.id) {