mirror of
https://github.com/pre-commit/pre-commit.git
synced 2026-01-14 13:00:10 -06:00
respect aliases in SKIP when installing environments
This commit is contained in:
@@ -420,7 +420,11 @@ def run(
|
||||
return 1
|
||||
|
||||
skips = _get_skips(environ)
|
||||
to_install = [hook for hook in hooks if hook.id not in skips]
|
||||
to_install = [
|
||||
hook
|
||||
for hook in hooks
|
||||
if hook.id not in skips and hook.alias not in skips
|
||||
]
|
||||
install_hook_envs(to_install, store)
|
||||
|
||||
return _run_hooks(config, hooks, skips, args)
|
||||
|
||||
@@ -635,6 +635,32 @@ def test_skip_bypasses_installation(cap_out, store, repo_with_passing_hook):
|
||||
assert ret == 0
|
||||
|
||||
|
||||
def test_skip_alias_bypasses_installation(
|
||||
cap_out, store, repo_with_passing_hook,
|
||||
):
|
||||
config = {
|
||||
'repo': 'local',
|
||||
'hooks': [
|
||||
{
|
||||
'id': 'skipme',
|
||||
'name': 'skipme-1',
|
||||
'alias': 'skipme-1',
|
||||
'entry': 'skipme',
|
||||
'language': 'python',
|
||||
'additional_dependencies': ['/pre-commit-does-not-exist'],
|
||||
},
|
||||
],
|
||||
}
|
||||
add_config_to_repo(repo_with_passing_hook, config)
|
||||
|
||||
ret, printed = _do_run(
|
||||
cap_out, store, repo_with_passing_hook,
|
||||
run_opts(all_files=True),
|
||||
{'SKIP': 'skipme-1'},
|
||||
)
|
||||
assert ret == 0
|
||||
|
||||
|
||||
def test_hook_id_not_in_non_verbose_output(
|
||||
cap_out, store, repo_with_passing_hook,
|
||||
):
|
||||
|
||||
Reference in New Issue
Block a user