Handle when the hooks directory is not there on install. Resolves #234.

This commit is contained in:
Anthony Sottile
2015-05-23 20:02:42 -07:00
parent b4bc5e4742
commit a97cb38b9a
2 changed files with 13 additions and 0 deletions

View File

@@ -48,6 +48,9 @@ def install(runner, overwrite=False, hooks=False, hook_type='pre-commit'):
hook_path = runner.get_hook_path(hook_type)
legacy_path = hook_path + '.legacy'
if not os.path.exists(os.path.dirname(hook_path)):
os.makedirs(os.path.dirname(hook_path))
# If we have an existing hook, move it to pre-commit.legacy
if (
os.path.exists(hook_path) and

View File

@@ -5,6 +5,7 @@ import io
import os
import os.path
import re
import shutil
import subprocess
import sys
@@ -78,6 +79,15 @@ def test_install_pre_commit(tmpdir_factory):
assert pre_push_contents == expected_contents
def test_install_hooks_directory_not_present(tmpdir_factory):
path = git_dir(tmpdir_factory)
# Simulate some git clients which don't make .git/hooks #234
shutil.rmtree(os.path.join(path, '.git', 'hooks'))
runner = Runner(path)
install(runner)
assert os.path.exists(runner.pre_commit_path)
def test_uninstall_does_not_blow_up_when_not_there(tmpdir_factory):
path = git_dir(tmpdir_factory)
runner = Runner(path)