mirror/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter.git synced 2026-01-07 21:50:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

dev: allow apps to sign files in their AppData

Browse Source
This commit is contained in:
KernelDeimos
2025-06-17 13:12:25 -04:00
parent 6315020cc0
commit 352ec6d883
1 changed files with 54 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
src/backend/src/routers/sign.js
View File

@@ -21,7 +21,8 @@ const {sign_file, get_app} = require('../helpers');
const eggspress = require('../api/eggspress.js');
const APIError = require('../api/APIError.js');
const { Context } = require('../util/context.js');
const { UserActorType } = require('../services/auth/Actor.js');
const { UserActorType, AppUnderUserActorType } = require('../services/auth/Actor.js');
const { NodePathSelector } = require('../filesystem/node/selectors.js');
// -----------------------------------------------------------------------//
// POST /sign
@@ -34,9 +35,7 @@ module.exports = eggspress('/sign', {
allowedMethods: ['POST'],
}, async (req, res, next)=>{
const actor = Context.get('actor');
if ( ! (actor.type instanceof UserActorType) ) {
throw APIError.create('forbidden');
}
const svc_fs = Context.get('services').get('filesystem');
if(!req.body.items) {
throw APIError.create('field_missing', null, { key: 'items' });
@@ -45,7 +44,56 @@ module.exports = eggspress('/sign', {
let items = Array.isArray(req.body.items) ? req.body.items : [res];
let signatures = [];
const svc_fs = Context.get('services').get('filesystem');
// Static request validation happens first
for ( const item of items ) {
if ( ! item ) {
throw APIError.create('field_invalid', null, {
key: `items`,
expected: 'each item to have: (uid OR path) AND action'
}).serialize()
}
if ( typeof item !== 'object' || Array.isArray(item) ) {
throw APIError.create('field_invalid', null, {
key: `items`,
expected: 'each item to be an object'
}).serialize()
}
// validation
if((!item.uid && !item.path)|| !item.action){
throw APIError.create('field_invalid', null, {
key: `items`,
expected: 'each item to have: (uid OR path) AND action'
}).serialize()
}
if ( typeof item.uid !== 'string' && typeof item.path !== 'string' ) {
throw APIError.create('field_invalid', null, {
key: `items`,
expected: 'each item to have only string values for uid and path'
}).serialize()
}
}
// Usually, only users can sign
if ( ! (actor.type instanceof UserActorType) ) {
if ( ! (actor.type instanceof AppUnderUserActorType) ) {
throw APIError.create('forbidden');
}
// But, apps can sign files in their own AppData directory
for ( const item of req.body.items ) {
const node = await svc_fs.node(item);
const appdata_path = `/${actor.type.user.username}/AppData/${actor.type.app.uid}`
const appdata_node = await svc_fs.node(new NodePathSelector(appdata_path));
if ( ! appdata_node.is_above(node) ) {
throw APIError.create('forbidden');
}
}
}
const result = {
signatures
@@ -71,37 +119,7 @@ module.exports = eggspress('/sign', {
result.token = token;
}
for (let index = 0; index < items.length; index++) {
let item = items[index];
if ( ! item ) {
throw APIError.create('field_invalid', null, {
key: 'items',
expected: 'each item to have: (uid OR path) AND action'
}).serialize()
}
if ( typeof item !== 'object' || Array.isArray(item) ) {
throw APIError.create('field_invalid', null, {
key: 'items',
expected: 'each item to be an object'
}).serialize()
}
// validation
if((!item.uid && !item.path)|| !item.action){
throw APIError.create('field_invalid', null, {
key: 'items',
expected: 'each item to have: (uid OR path) AND action'
}).serialize()
}
if ( typeof item.uid !== 'string' && typeof item.path !== 'string' ) {
throw APIError.create('field_invalid', null, {
key: 'items',
expected: 'each item to have only string values for uid and path'
}).serialize()
}
for ( const item of items ) {
const node = await svc_fs.node(item);
if ( ! await node.exists() ) {