mirror of
https://github.com/HeyPuter/puter.git
synced 2025-12-30 01:29:58 -06:00
fix: pass exporter to NodeSDK constructor
Previously a new ConsoleSpanExporter was passed to the constructor of
NodeSDK. This was possibly unintentional but it did not cause any
issues. After the recent update to opentelemetry, or perhaps the changes
introduced in 3c579dcc0d, this no longer
works as it prevents tools like Jaeger from getting any spans from
Puter's backend.
This commit is contained in:
@@ -23,8 +23,7 @@ const { PeriodicExportingMetricReader, ConsoleMetricExporter } = require('@opent
|
||||
|
||||
const { Resource } = require('@opentelemetry/resources');
|
||||
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
|
||||
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
|
||||
const { ConsoleSpanExporter, BatchSpanProcessor } = require('@opentelemetry/sdk-trace-base');
|
||||
const { ConsoleSpanExporter } = require('@opentelemetry/sdk-trace-base');
|
||||
const config = require('../../config');
|
||||
const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc');
|
||||
|
||||
@@ -40,16 +39,10 @@ class TelemetryService extends BaseService {
|
||||
|
||||
const exporter = this.#getConfiguredExporter();
|
||||
this.exporter = exporter;
|
||||
const processor = new BatchSpanProcessor(exporter);
|
||||
const provider = new NodeTracerProvider({ resource,
|
||||
spanProcessors: [
|
||||
processor,
|
||||
] });
|
||||
|
||||
provider.register();
|
||||
|
||||
const sdk = new NodeSDK({
|
||||
traceExporter: new ConsoleSpanExporter(),
|
||||
resource,
|
||||
traceExporter: exporter,
|
||||
metricReader: new PeriodicExportingMetricReader({
|
||||
exporter: new ConsoleMetricExporter(),
|
||||
}),
|
||||
|
||||
Reference in New Issue
Block a user