mirror/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter.git synced 2026-02-24 19:08:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: try catching icon read errors before stream

Browse Source 
Current issue with get-launch-apps wasn't fixed by catching errors while
reading the stream so this next attempt catches errors from the call to
start reading.

If the error occurs asynchronously this may not work either.
This commit is contained in:
KernelDeimos
2024-12-23 09:48:28 -05:00
parent e736e428d6
commit e56a62c539
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/backend/src/services/AppIconService.js
View File

@@ -84,7 +84,8 @@ class AppIconService extends BaseService {
const dir_app_icons = await this.get_app_icons();
console.log('APP UID', app_uid);
const node = await dir_app_icons.getChild(`${app_uid}-${size}.png`);
if ( ! await node.exists() ) {
const get_fallback_icon = async () => {
// Use database-stored icon as a fallback
app_icon = app_icon ?? await (async () => {
const app = await get_app({ uid: app_uid });
@@ -100,15 +101,26 @@ class AppIconService extends BaseService {
};
}
const svc_su = this.services.get('su');
const ll_read = new LLRead();
return {
mime: 'image/png',
stream: await ll_read.run({
fsNode: node,
actor: await svc_su.get_system_actor(),
})
};
if ( ! await node.exists() ) {
return await get_fallback_icon();
}
try {
const svc_su = this.services.get('su');
const ll_read = new LLRead();
return {
mime: 'image/png',
stream: await ll_read.run({
fsNode: node,
actor: await svc_su.get_system_actor(),
})
};
} catch (e) {
this.errors.report('AppIconService.get_icon_stream', {
source: e,
});
return await get_fallback_icon();
}
}
/**