JaviPege 9d1f2c87d5 CRITICAL: Add exit 1 after ALL log_error calls to abort on failure ...

**MAJOR BUG:**
The installer was continuing execution after critical errors, leading to:
- Infinite loops waiting for services that will never respond
- Cascading failures as dependent operations try to use invalid state
- User confusion as errors scroll by but script keeps running

**Problems Fixed:**

1. **configure_arr_service()** - Now exits if:
   - API key extraction fails (was: return 1, continued)
   - Root folder creation fails (was: log error, continued)
   - Download client addition fails (was: log error, continued)
   - Remote path mapping is non-critical, logs warning only

2. **add_arr_to_prowlarr()** calls in setup.sh - Now exits if:
   - Failed to add Radarr to Prowlarr (was: log error, continued)
   - Failed to add Sonarr to Prowlarr (was: log error, continued)

3. **API key extraction** in setup.sh - Now exits if:
   - Any of the three API keys (Radarr/Sonarr/Prowlarr) are empty
   - Shows which specific keys are missing
   - Provides docker logs command to troubleshoot

**Result:**
- Script now STOPS IMMEDIATELY when a critical operation fails
- Clear error messages explain what failed and how to debug
- Logs are preserved for troubleshooting
- No more infinite loops or cascading failures

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-10-22 13:32:09 +02:00

443 B

Raw Blame History

View Raw