mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-19 10:20:17 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix static analyzer issues (#1727)

Browse Source 
* Fix `barsGroup` memory leak

* Remove unused values
This commit is contained in:
Iulian Onofrei
2019-02-09 21:37:55 +02:00
committed by mgrojo
parent 3eebffd7c6
commit 1ebd9955ca
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/PlotDock.cpp
View File

@@ -776,10 +776,15 @@ void PlotDock::toggleLegendVisible(bool visible)
void PlotDock::adjustBars()
{
const double padding = 0.15;
const double groupedWidth = ui->plotWidget->plottableCount()? 1.0 / ui->plotWidget->plottableCount() : 0.0;
int plottableCount = ui->plotWidget->plottableCount();
if (plottableCount == 0)
return;
const double groupedWidth = 1.0 / plottableCount;
QCPBars* previousBar = nullptr;
QCPBarsGroup* barsGroup = m_stackedBars? nullptr : new QCPBarsGroup(ui->plotWidget);
for (int i = 0, ie = ui->plotWidget->plottableCount(); i < ie; ++i)
QCPBarsGroup* barsGroup = m_stackedBars ? nullptr : new QCPBarsGroup(ui->plotWidget);
for (int i = 0, ie = plottableCount; i < ie; ++i)
{
QCPBars* bar = qobject_cast<QCPBars*>(ui->plotWidget->plottable(i));
if (bar) {

10
src/csvparser.cpp
View File

@@ -189,7 +189,7 @@ CSVParser::ParserResult CSVParser::parse(csvRowFunction insertFunction, QTextStr
// no linefeed, so assume that CR represents a newline
if(nit != sBufferEnd && *nit != '\n')
{
field = addColumn(record, field, m_bTrimFields);
addColumn(record, field, m_bTrimFields);
if(!(field = addRow(insertFunction, record, parsedRows)))
return ParserResult::ParserResultError;
@@ -197,7 +197,7 @@ CSVParser::ParserResult CSVParser::parse(csvRowFunction insertFunction, QTextStr
}
else if(c == '\n')
{
field = addColumn(record, field, m_bTrimFields);
addColumn(record, field, m_bTrimFields);
if(!(field = addRow(insertFunction, record, parsedRows)))
return ParserResult::ParserResultError;
@@ -235,7 +235,7 @@ CSVParser::ParserResult CSVParser::parse(csvRowFunction insertFunction, QTextStr
else if(c == '\n')
{
state = StateNormal;
field = addColumn(record, field, m_bTrimFields);
addColumn(record, field, m_bTrimFields);
if(!(field = addRow(insertFunction, record, parsedRows)))
return ParserResult::ParserResultError;
@@ -257,7 +257,7 @@ CSVParser::ParserResult CSVParser::parse(csvRowFunction insertFunction, QTextStr
// no linefeed, so assume that CR represents a newline
if(nit != sBufferEnd && *nit != '\n')
{
field = addColumn(record, field, m_bTrimFields);
addColumn(record, field, m_bTrimFields);
if(!(field = addRow(insertFunction, record, parsedRows)))
return ParserResult::ParserResultError;
@@ -285,7 +285,7 @@ CSVParser::ParserResult CSVParser::parse(csvRowFunction insertFunction, QTextStr
if(record.num_fields)
{
field = addColumn(record, field, m_bTrimFields);
addColumn(record, field, m_bTrimFields);
if(!(field = addRow(insertFunction, record, parsedRows)))
return ParserResult::ParserResultError;