mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Defer foreign keys during SQL import

Browse Source 
When importing an SQL file, defer foreign keys until the import is
finished. This is necessary if there are foreign key constraints in the
imported table and the order of the INSERT statements doesn't match the
hierarchy of the constraints.

Also perform an integrity check at the end of the import.

See issue #1519.
This commit is contained in:
Martin Kleusberg
2018-08-28 21:14:09 +02:00
parent ee736eb2dd
commit 406734a2c9
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/MainWindow.cpp
View File

@@ -1600,17 +1600,27 @@ void MainWindow::importDatabaseFromSQL()
loadExtensionsFromSettings();
}
// Defer foreign keys. Just deferring them instead of disabling them should work fine because in the import we only expect CREATE and INSERT
// statements which unlike in the Edit Table dialog shouldn't trigger any problems.
QString foreignKeysOldSettings = db.getPragma("defer_foreign_keys");
db.setPragma("defer_foreign_keys", "1");
// Open, read, execute and close file
QApplication::setOverrideCursor(Qt::WaitCursor);
QFile f(fileName);
f.open(QIODevice::ReadOnly);
if(!db.executeMultiSQL(f.readAll(), newDbFile.size() == 0))
QMessageBox::warning(this, QApplication::applicationName(), tr("Error importing data: %1").arg(db.lastError()));
else if(db.getPragma("foreign_keys") == "1" && !db.querySingeValueFromDb(QString("PRAGMA foreign_key_check")).isNull())
QMessageBox::warning(this, QApplication::applicationName(), tr("Import complated. Some foreign key constraints are violated. Please fix them before saving."));
else
QMessageBox::information(this, QApplication::applicationName(), tr("Import completed."));
f.close();
QApplication::restoreOverrideCursor();
// Restore the former foreign key settings
db.setPragma("defer_foreign_keys", foreignKeysOldSettings);
// Refresh window when importing into an existing DB or - when creating a new file - just open it correctly
if(newDbFile.size())
{