mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix alterTable() function when renaming a column

Browse Source 
When renaming a column using SQLite >= 3.25 and changing something else
in the table, you would lose all the data in the renamed column. This is
because the second part of the alterTable() function (the part after the
renaming) didn't know about the new column name and so assumed it still
to be the old one.

See issue #1650.
This commit is contained in:
Martin Kleusberg
2018-12-07 20:50:23 +01:00
parent b42097c704
commit 47422f36c7
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sqlitedb.cpp
View File

@@ -1435,7 +1435,10 @@ bool DBBrowserDB::alterTable(const sqlb::ObjectIdentifier& tablename, const sqlb
// Newer versions of SQLite add a better ALTER TABLE support which we can use
#if SQLITE_VERSION_NUMBER >= 3025000
// If the name of a field should be changed do that by using SQLite's ALTER TABLE feature
// If the name of a field should be changed do that by using SQLite's ALTER TABLE feature. We build a new
// map for tracking column names here which uses the update column names as the old names too. This is to
// make sure we are using the new table layout for later updates.
AlterTableTrackColumns new_track_columns;
for(const auto& old_name : track_columns.keys())
{
QString new_name = track_columns[old_name];
@@ -1453,8 +1456,12 @@ bool DBBrowserDB::alterTable(const sqlb::ObjectIdentifier& tablename, const sqlb
}
changed_something = true;
new_track_columns.insert(new_name, new_name);
} else {
new_track_columns.insert(old_name, new_name);
}
}
track_columns.swap(new_track_columns);
#endif
// Update our schema representation to get the new table and all the changed triggers, views and indices