mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-17 01:09:36 -06:00
Code Issues Packages Projects Releases Wiki Activity

Export: use QSaveFile to get better error check on full partition

Browse Source 
Note that, at least under Linux, this will still fail to detect the
error due to this Qt bug: https://bugreports.qt.io/browse/QTBUG-75077

See issue #3243
This commit is contained in:
mgrojo
2022-12-27 23:44:26 +01:00
parent ce176be2b4
commit 496d39db3a
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/ExportDataDialog.cpp
View File

@@ -7,7 +7,7 @@
#include "IconCache.h"
#include "Data.h"
#include <QFile>
#include <QSaveFile>
#include <QTextStream>
#include <QMessageBox>
#include <QTextCodec>
@@ -109,7 +109,7 @@ bool ExportDataDialog::exportQueryCsv(const std::string& sQuery, const QString&
std::string special_chars = newlineStr.toStdString() + sepChar.toLatin1() + quoteChar.toLatin1();
bool writeError = false;
// Open file
QFile file(sFilename);
QSaveFile file(sFilename);
if(file.open(QIODevice::WriteOnly))
{
// Open text stream to the file
@@ -186,7 +186,9 @@ bool ExportDataDialog::exportQueryCsv(const std::string& sQuery, const QString&
qApp->processEvents();
// Done writing the file
file.close();
if(!file.commit()) {
writeError = true;
}
if(writeError || file.error() != QFileDevice::NoError) {
QMessageBox::warning(this, QApplication::applicationName(),
@@ -207,7 +209,7 @@ bool ExportDataDialog::exportQueryCsv(const std::string& sQuery, const QString&
bool ExportDataDialog::exportQueryJson(const std::string& sQuery, const QString& sFilename)
{
// Open file
QFile file(sFilename);
QSaveFile file(sFilename);
if(file.open(QIODevice::WriteOnly))
{
auto pDb = pdb.get(tr("exporting JSON"));
@@ -289,7 +291,9 @@ bool ExportDataDialog::exportQueryJson(const std::string& sQuery, const QString&
qApp->processEvents();
// Done writing the file
file.close();
if(!file.commit()) {
writeError = true;
}
if(writeError || file.error() != QFileDevice::NoError) {
QMessageBox::warning(this, QApplication::applicationName(),