mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Disable editing of cells in views in Browse Data tab when not enabled

Browse Source 
See issue #2091.
This commit is contained in:
Martin Kleusberg
2020-01-16 17:20:19 +01:00
parent a657d2bff6
commit 54866e1827
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/TableBrowser.cpp
View File

@@ -744,7 +744,12 @@ void TableBrowser::updateRecordsetLabel()
}
ui->labelRecordset->setText(txt);
enableEditing(m_model->rowCountAvailable() != SqliteTableModel::RowCount::Unknown);
// Enable editing only for tables or views with editing unlocked for which the row count is already available
sqlb::ObjectIdentifier current_table = currentlyBrowsedTableName();
bool is_table_or_unlocked_view = !m_model->query().empty() && db->getObjectByName(current_table) && (
(db->getObjectByName(current_table)->type() == sqlb::Object::View && m_model->hasPseudoPk()) ||
(db->getObjectByName(current_table)->type() == sqlb::Object::Table));
enableEditing(m_model->rowCountAvailable() != SqliteTableModel::RowCount::Unknown && is_table_or_unlocked_view);
}
void TableBrowser::applySettings(const BrowseDataTableSettings& storedData, bool skipFilters)