mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 02:50:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

Check if some column has a NOT NULL constraint in "Set to NULL"

Browse Source 
Before setting any cell value to NULL, the existence of a NOT NULL
constraint is checked in the selected columns of the current table. This
avoid raising several warning messages when the DB rejects the individual
values.

See issue #2021.
This commit is contained in:
mgrojo
2019-12-16 22:23:59 +01:00
parent 8e8a3aa216
commit cac0ae1e8c
2 changed files with 25 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/ExtendedTableWidget.cpp
View File

@@ -362,8 +362,7 @@ ExtendedTableWidget::ExtendedTableWidget(QWidget* parent) :
});
connect(nullAction, &QAction::triggered, [&]() {
for(const QModelIndex& index : selectedIndexes())
model()->setData(index, QVariant());
setToNull(selectedIndexes());
});
connect(copyAction, &QAction::triggered, [&]() {
copy(false, false);
@@ -810,8 +809,7 @@ void ExtendedTableWidget::keyPressEvent(QKeyEvent* event)
if(event->modifiers().testFlag(Qt::AltModifier))
{
// When pressing Alt+Delete set the value to NULL
for(const QModelIndex& index : selectedIndexes())
model()->setData(index, QVariant());
setToNull(selectedIndexes());
} else {
// When pressing Delete only set the value to empty string
for(const QModelIndex& index : selectedIndexes())
@@ -1043,3 +1041,24 @@ void ExtendedTableWidget::currentChanged(const QModelIndex &current, const QMode
QTableView::currentChanged(current, previous);
emit currentIndexChanged(current, previous);
}
void ExtendedTableWidget::setToNull(const QModelIndexList& indices)
{
SqliteTableModel* m = qobject_cast<SqliteTableModel*>(const_cast<QAbstractItemModel*>(model()));
sqlb::TablePtr currentTable = m->db().getObjectByName<sqlb::Table>(m->currentTableName());
// Check if some column in the selection has a NOT NULL constraint, before trying to update the cells.
if(currentTable)
for(const QModelIndex& index : indices) {
const sqlb::Field& field = currentTable->fields.at(static_cast<size_t>(index.column())-1);
if(field.notnull()) {
QMessageBox::warning(nullptr, qApp->applicationName(),
tr("Cannot set selection to NULL. Column %1 has a NOT NULL constraint.").
arg(QString::fromStdString(field.name())));
return;
}
}
for(const QModelIndex& index : indices)
model()->setData(index, QVariant());
}

2
src/ExtendedTableWidget.h
View File

@@ -84,6 +84,8 @@ private:
void useAsFilter(const QString& filterOperator, bool binary = false, const QString& operatorSuffix = QString());
void duplicateUpperCell();
void setToNull(const QModelIndexList& indices);
static std::vector<std::vector<QByteArray>> m_buffer;
static QString m_generatorStamp;