mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-05-19 12:08:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix error message when renaming/moving/modifying column

Browse Source 
When modifying a column e.g. renaming it there was a case where an error
message would be shown because of invalid SAVEPOINT handling. Try to fix
this issue by not creating a SAVEPOINT for creating a SAVEPOINT.

This should fix issue #390.
This commit is contained in:
Martin Kleusberg
2015-08-06 14:37:12 +02:00
parent 397ae1b7b9
commit ce40d555f1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/sqlitedb.cpp
+2 -2
View File
@@ -906,7 +906,7 @@ bool DBBrowserDB::renameColumn(const QString& tablename, const QString& name, sq
}
// Create savepoint to be able to go back to it in case of any error
if(!executeSQL("SAVEPOINT sqlitebrowser_rename_column"))
if(!executeSQL("SAVEPOINT sqlitebrowser_rename_column", false))
{
lastErrorMessage = tr("renameColumn: creating savepoint failed. DB says: %1").arg(lastErrorMessage);
qWarning() << lastErrorMessage;
@@ -1008,7 +1008,7 @@ bool DBBrowserDB::renameColumn(const QString& tablename, const QString& name, sq
}
// Release the savepoint - everything went fine
if(!executeSQL("RELEASE SAVEPOINT sqlitebrowser_rename_column;"))
if(!executeSQL("RELEASE SAVEPOINT sqlitebrowser_rename_column;", false))
{
lastErrorMessage = tr("renameColumn: releasing savepoint failed. DB says: %1").arg(lastErrorMessage);
qWarning() << lastErrorMessage;