mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

When renaming a table column try to fix all indices referencing the column

Browse Source 
Suppose you have this database:
CREATE TABLE a(
    x INTEGER,
    y INTEGER
);
CREATE INDEX i ON a(x ASC);

Now, when trying to rename column x of table a to some other name using
the Edit Table dialog will work but index i will be lost during the
process. This is because it needs to be recreated after having modified
the table, however its create statement isn't valid anymore because the
column name x doesn't exist anymore. This is changed by this commit to
significantly increase the chance that renaming a column won't throw an
error, thus making the Edit Table dialog a lot safer to use.
This commit is contained in:
Martin Kleusberg
2017-01-20 12:51:14 +01:00
parent 2c7f32c699
commit dc934a7ec7
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/sqlitedb.cpp
View File

@@ -1085,7 +1085,24 @@ bool DBBrowserDB::renameColumn(const QString& tablename, const sqlb::Table& tabl
{
// If this object references the table and it's not the table itself save it's SQL string
if((*it).getTableName() == tablename && (*it).gettype() != "table")
otherObjectsSql += (*it).getsql().trimmed() + ";\n";
{
// If this is an index, update the fields first. This highly increases the chance that the SQL statement won't throw an
// error later on when we try to recreate it.
if((*it).gettype() == "index")
{
sqlb::Index idx = (*it).index;
for(int i=0;i<idx.columns().size();i++)
{
if(idx.column(i)->name() == name)
idx.column(i)->setName(to->name());
}
otherObjectsSql += idx.sql() + "\n";
} else {
// If it's a view or a trigger we don't have any chance to corrections yet. Just store the statement as is and
// hope for the best.
otherObjectsSql += (*it).getsql().trimmed() + ";\n";
}
}
}
// We need to disable foreign keys here. The reason is that in the next step the entire table will be dropped and there might be foreign keys